GerLech / WebConfig

For ESP8266 and ESP32 edit configuration with web page and save it on SPIFFS. If no connection to a local WLAN exists configuration over web page can be done using an access point
GNU Lesser General Public License v3.0
80 stars 19 forks source link

setXXXX() function #4

Closed infrafast closed 4 years ago

infrafast commented 4 years ago

Hello, I am using the library, very good job! we have access to the values of a parameter so we could presumably change it via

values[conf.getindex("mytrack")]=xxx

however I think it would make sense to implement the code into a setValue(paramName) and also:

I am planning to do that anyway so I can either submit a pullrequest or fork but maybe you planned to do that anyway ? Thanks Thomas

bool WebConfig::setParamOption(const char paramName,int j,const char optionL, const char * optionV){ return setParamOption(getIndex(paramName),j,optionL,optionV); }

bool WebConfig::setParamOption(int i,int j,const char optionL, const char optionV){ if (j<MAXOPTIONS && i<_count;){ _description[i].options[j] = optionV; _description[i].labels[j] = optionL; return true; }else return false; }

GerLech commented 4 years ago

I added the suggested functions and some more. I released the new version 1.2 today

infrafast commented 4 years ago

great thanks!


De : Gerald Lechner notifications@github.com Envoyé : mercredi 5 février 2020 14:11 À : GerLech/WebConfig WebConfig@noreply.github.com Cc : infrafast info@infrafast.com; Author author@noreply.github.com Objet : Re: [GerLech/WebConfig] setXXXX() function (#4)

I added the suggested functions and some more. I released the new version 1.2 today

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/GerLech/WebConfig/issues/4?email_source=notifications&email_token=AFAQXR53XBWC55M37AWMOPLRBK3H3A5CNFSM4KEXD2HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK3LQ2Q#issuecomment-582400106, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFAQXR2PGCQPDXV3NNN6V7TRBK3H3ANCNFSM4KEXD2HA.