Hard- & software stack for authentication, authorization and accounting of your private beer tap via RFID tokens. Created by the Geraffel gang, it runs reliably on very simple and cheap hardware.
GNU General Public License v2.0
6
stars
2
forks
source link
Refactor class capsulation, nesting and interfacing #24
Currently, the implementation is not fully object-oriented. We're missing full object-based implementation for
beernary_lcd.py
beernary_configuration.py
Further more, beernary_lcd.py is required to be abstracted from hardware in case of changes, like implemented in beernary_database. This can help handling LCD_LINES and STDOUT-forwarding too.
Also, UsbRfid and SerialRfid in beernary_reader.py could be implemented via a common object and specific characteristics could be overloaded instead of having to classes.
For all code, modules and implementation in beernary_counter.py and beernary_registry.py, proper encapsulation and reusability needs to be restored.
ziehmon
commented
1 year ago
Currently, the implementation is not fully object-oriented. We're missing full object-based implementation for
beernary_lcd.pybeernary_configuration.pyFurther more,
beernary_lcd.pyis required to be abstracted from hardware in case of changes, like implemented inbeernary_database. This can help handlingLCD_LINESandSTDOUT-forwarding too.Also,
UsbRfidandSerialRfidinbeernary_reader.pycould be implemented via a common object and specific characteristics could be overloaded instead of having to classes.For all code, modules and implementation in
beernary_counter.pyandbeernary_registry.py, proper encapsulation and reusability needs to be restored.