search

Geraffel-Village / Beernary

Hard- & software stack for authentication, authorization and accounting of your private beer tap via RFID tokens. Created by the Geraffel gang, it runs reliably on very simple and cheap hardware.
GNU General Public License v2.0
6 stars 2 forks source link

Remove hardcoded database credentials #9

Closed SvenRoederer closed 5 years ago

SvenRoederer commented 5 years ago

In https://github.com/phl0/b33rn4rycounter/blob/9b71a08f42b3e57b9f64c90ba93cc285676be60a/B33rn4ryDatabase.py#L82 the credentials to the database are hardcoded. We should implement a local config-file for this. This config-file should not be avail on github.

phl0 commented 5 years ago

Closed via https://github.com/phl0/b33rn4rycounter/commit/e6bf01deab9861543c3f85e993383431f52493c8

SvenRoederer commented 5 years ago

But we should change the credentials of the system, as the old data are still in the commit-history

phl0 commented 5 years ago

Sure!