Gerben321 / bike-care-tracker

Issue/Suggestion tracker for Bike Care app
3 stars 0 forks source link

Missing bike identification in service schedule view #26

Closed OleksiyRudenko closed 3 months ago

OleksiyRudenko commented 3 months ago

Describe the bug Bike identification is not available/visible in specific service schedule view for an installed component.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://bikecare.gerbenbol.com/dashboard/service-schedules
  2. Click on Details of any service entry
  3. Observe missing bike identification for an installed component (see screenshot)

Expected behavior A bike identification is present and visible

Screenshots image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context n/a

Gerben321 commented 3 months ago

Thanks for the detailed issue! That should indeed be there. I'll have a look.

OleksiyRudenko commented 3 months ago

On a second thought, it also would be nice to know (see) what is the type of component. In this particular case I have a Kenda tyre (actually two of them :) ) but from this view I cannot tell if it is a front or rear wheel.

Gerben321 commented 3 months ago

Yeah that would be useful. I think the whole visual of this card needs to be uncluttered so if you think something can be removed or moved let me know.

OleksiyRudenko commented 3 months ago

Yeah, probably worth revamping when you are going to touch the component at all. Here is the proposal for the text block before the ring chart with some heavily opinionated explanations.

(I am sorry, I cannot confidently suggest any proper Dutch translations)

Mockup / example:

Tyres check 🚲 Bike Name Front wheel: Kenda tyre 26x2.1 Distance to service: 1,760 km (imagine it is of green color :-) ) Distance done: 39.53 km Service frequency: 1,800 km of Total distance Last service: N/A

Comments:

Gerben321 commented 3 months ago

Turns out the bike make and model are used to display the name there. This will be changed to the big 'nickname' used in other places. I'll have a look at your ideas to improve the display of the rest now.

Gerben321 commented 3 months ago

This is what I've changed so far: image I've followed most of your feedback I believe. I think the rounded numbers look a lot cleaner as well! Let me know if I've missed something or change something else. The ring is now also inverted. Because the text in the center is 'x left' I found it more logical that the bar would also show how much is left, instead of how much is done. What do you think?

OleksiyRudenko commented 3 months ago

The ring is now also inverted. Because the text in the center is 'x left' I found it more logical that the bar would also show how much is left, instead of how much is done. What do you think?

I agree 👍

Gerben321 commented 3 months ago

Deployed right now.