Gerben321 / bike-care-tracker

Issue/Suggestion tracker for Bike Care app
3 stars 0 forks source link

Service urgency/criticality visualization is not consistent across the app #37

Closed OleksiyRudenko closed 2 months ago

OleksiyRudenko commented 2 months ago

Describe the bug The app draws attention to a service due soon... ... on the dashboard

image

... and in the bikes list

image

But not on the schedule list.

image

To Reproduce Steps to reproduce the behavior:

  1. Go to https://bikecare.gerbenbol.com/dashboard/service-schedules
  2. See incosistent status icon when the service is due soon or overdue

Expected behavior The service status icon is either yellow or red when the service is due soon or overdue.

Screenshots See as embedded above.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context n/a

Gerben321 commented 2 months ago

Good find. There's indeed a bit of a difference there. The table only shows overdue, and the other places show almost or overdue.

Indeed a third color would be good. Green for good, yellow for maybe 15% left, and red for overdue? On the pie chart there is green and yellow and orange and red. But that might be overkill for other places.

What do you think? That way I can apply that everywhere.

OleksiyRudenko commented 2 months ago

To me, yellow (with whatever rule you currently have already got in place) for the nearing service and red for overdue would work perfectly fine.

Orange might be good on service with longer utilization period, like chain or cassette replacements (when 15% with yellow is rather early heads-up). Would be nice to predict 1 day due. I.e. in this scenario yellow would stand for "buy a replacement", and orange "be ready to replace in a day or two".

Upd: for a frequent service, like oiling, orange may not make much sense. From the other hand if I get used to have an orange from time to time as a last warning I can easily overlook the yellow status. Maybe for frequent services it makes sense to warn with orange, omitting yellow warning. I do not know, sitting on the fence.

Gerben321 commented 2 months ago

This is my proposal: image

image

And on the component and bike list I will add the icons like for the schedules. I think that should make everything more consistent.

image The bike will show the overall lowest icon. So if there's a schedule that's orange, and one that's red, it will show red. If there's one orange and 2 green, it will show orange.

Gerben321 commented 2 months ago

I've deployed this update, let me know what you think. Feel free to drop a comment if the percentages need some work or if you still found something that's inconsistent!