Gerben321 / bike-care-tracker

Issue/Suggestion tracker for Bike Care app
3 stars 0 forks source link

Active/Inactive vs Mounted/Unmounted vs Usable/Retired component #64

Closed OleksiyRudenko closed 1 month ago

OleksiyRudenko commented 1 month ago

Is your feature request related to a problem? Please describe. A component's Active property sounds ambiguous. It would be great to have more explicit and specific properties names. E.g. Mounted (meaning it is mounted on a bike), Retired (if a component is decomissioned and no longer would be mounted or serviced, kept on record for history backtracking purposes and for data consistency reasons).

Describe the solution you'd like Change component property names to more specific.

Describe alternatives you've considered Remembering the property meaning and deducing it by changing the value and figure the consequences out.

Gerben321 commented 1 month ago

Yeah, like we discussed this is a good idea. What would be the best terms?

When a component is still good to use, but is installed on your bike, or not:

And when a component is no longer used, and will not be used anymore (broken, worn, etc):

@Konstantin-Levin Could you also help us think about this? This might be useful for you as well, since you're using a lot more bikes and components then we are, I think. 😎

OleksiyRudenko commented 1 month ago

Thank you for looking into this. I have also added a couple more feature requests to deal with mounting and swapping components.

My rationale behind the term "Retired" was Strava's term. If BikeCare used the same term users will have proper mental connection between actions in Strava and in BikeCare.

Screenshot from Strava: image

Gerben321 commented 1 month ago

I agree with that. That would sound good to keep the same term. And the placement in your screenshot also sounds good.

Konstantin-Levin commented 1 month ago

I agree with all of the above regarding the wording. I think each component could fall into 1 of 3 states.

  1. Mounted
  2. Unmounted
  3. Retired

I've got a few other ideas about retiring components. I'll put them in #65 as it seems the better place

Gerben321 commented 1 month ago

I've just deployed a new version which got rid of the active toggle. It has changed to retired, which is off by default.

The rest is still the same, just changed same naming. Next up will be the mounted or not mounted display.

Gerben321 commented 1 month ago

Here's a simple example of how it will look like: image The last install period is fetched, and the frontend will 'calculate' whether it's installed or not. It will then put it in the correct list and show it. I think I will also add a filter for this.

Gerben321 commented 1 month ago

This is also deployed now. Let me know what you think 👍.