GerbilSoft / gens-gs-ii

Gens/GS II - an improved Gens/GS rewrite.
31 stars 9 forks source link

Elemental Master: HUD scrolls with screen (Bugzilla #40) #40

Closed GerbilSoft closed 8 years ago

GerbilSoft commented 8 years ago

status RESOLVED severity normal in component vdp/m5 for --- Reported in version _II 1.0beta1 on platform i386 Assigned to: David Korth

Original attachment names and IDs:

On 2011-02-18 11:10:19 -0500, Pietro Gagliardi (andlabs) wrote:

Created attachment 13 Example screenshot

In both Elemental Master (J) (crc32 5f553e29) and (U) (crc32 390918c6), the HUD scrolls as the screen scrolls (the game has autoscroll) while the indicator showing the current weapon type stays in its right spot.

On 2011-02-18 13:01:18 -0500, David Korth wrote:

commit SHA: 2e201e49f57f29b66f66f35a2d1427d11d0d3a60 Author: David Korth gerbilsoft@verizon.net Date: Fri Feb 18 12:52:18 2011 -0500

[libgens] VdpRend_m5::T_Render_Line_ScrollA(): Fixed window display for many games.

andlabs noticed that many games weren't showing the window region properly.

Elemental Master: Window was scrolling with Scroll B. (Turns out that
both Scroll B and the Window were set to the same area in VRAM, but
that was only a symptom of the bug.)

Vapor Trail: Window shows garbage.

Grind Stormer: Window is blank.

Fire Shark: Window initially works, but then is overwritten by the
main scroll planes.

Turns out the problem was the X offset wasn't being added for
right-aligned windows, so it was reading the wrong data.

This patch fixes the problem for the aforementioned games.

(My previous test ROM, Gauntlet 4, didn't show any problems because
it only used Scroll B for the main game area, and Scroll A was
basically ignored.  Scroll A and B were set to 0xE000, while Window
was set to 0xD000.)
GerbilSoft commented 8 years ago

emaster_scroll