search

GerbilSoft / rom-properties

ROM Properties Page shell extension
GNU General Public License v2.0
461 stars 35 forks source link

Underlying CD image type for ISO #322

Open DankRank opened 2 years ago

DankRank commented 2 years ago

Would be nice to know if a given image is MODE1/2352, MODE2/2352, or MODE[12]/2048 (i.e. plain ISO9660).

GerbilSoft commented 2 years ago

What I'll probably do here is rework the entire disc image handling to detect disc formats on a lower level (e.g. RomDataFactory). That way, things like the GameCube parser won't need to specifically check for CISO, WBFS, etc. As an added bonus, this means "any" compressed format will be usable for any system, though e.g. WBFS for PSP doesn't make much sense.

To go along with this, the IDiscReader interface will be updated to provide information about the disc image format, and various RomData subclasses that support disc images will add a tab for the physical layer if it'd have useful information.

This will probably be the last "big" feature for 1.9.

Masamune3210 commented 2 years ago

WBFS for a PSP game sounds like the most cursed thing ever

GerbilSoft commented 2 years ago

On second thought, this might be a bit too complicated for a last-minute addition. Pushing it back to 1.10.