search

Gerdofal / foundryvtt-cyberpunkred

GNU General Public License v3.0
20 stars 18 forks source link

check number of 6s in damage rolls for critical injuries (#51) #79

Closed njfox closed 3 years ago

njfox commented 3 years ago

This starts work on #51 by checking the damage roll results for the number of 6s, which are needed to figure out if you scored a critical injury. I don't actually know how to convey this information to the user, so I've opened this is a draft PR so we can discuss.

The number of 6's do already show up in the chat log, but it would probably be good to add some custom text to make it easier to read (e.g., Critical Injury! in red): crit-injuries

1's and 10's are probably covered by #77 unless I missed a use-case in the rules.

njfox commented 3 years ago

I think this is ready for review now. I used the green color code from the exploding dice for the "Critical Success!" text, but if you have a better option in mind I'm open to changing it.

Some screenshots to save you time testing:

crit-fail crit-success crit-injury

njfox commented 3 years ago

This should be ready unless you can think of anything else that needs work. Thanks!