GergelyTuri / tFC-rig

trace fear conditioning rig
GNU General Public License v3.0
0 stars 0 forks source link

KeyboardInterrupt aka ctrl-c does not work during ITI #24

Open YuechengShi opened 9 months ago

YuechengShi commented 9 months ago

KeyboardInterrupt aka ctrl-c does not work during ITI

cpaynerogers commented 6 months ago

@YuechengShi not sure if you will see this comment. I'll follow up on Slack or next time I'm on campus and can take a look at the setup / rig. I have a clarifying question before I could start thinking about addressing this issue:

My understanding of the current rig and serial read script is that the script is only communicating with the Arduino board serially, and it is only reading data. So, ctrl-c should stop the script from reading additional messages but I would be surprised if it also stops the Arduino board from executing, because I'm not aware of us using two-way communication with the board (of us sending messages to the board in addition to reading messages from the board)

GergelyTuri commented 1 month ago

@YuechengShi what's up with this?

YuechengShi commented 1 month ago

Oh sorry didn’t see this. When I press ctrl c during a trial it only stops the data collection but not the arduino itself, which require me pressing the reset buttons on the boards to end the trial.

On Thu, Aug 8, 2024 at 5:48 PM Gergo @.***> wrote:

@YuechengShi https://github.com/YuechengShi what's up with this?

— Reply to this email directly, view it on GitHub https://github.com/GergelyTuri/tFC-rig/issues/24#issuecomment-2276712649, or unsubscribe https://github.com/notifications/unsubscribe-auth/BB7NACOVMUXVFG4MGVSDS4DZQPRURAVCNFSM6AAAAABMHJ23JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZWG4YTENRUHE . You are receiving this because you were mentioned.Message ID: @.***>

GergelyTuri commented 1 month ago

How often do you need/use this functionality?

From: Yuecheng Shi @.> Sent: Thursday, August 8, 2024 5:57 PM To: GergelyTuri/tFC-rig @.> Cc: Turi, Gergely @.>; Comment @.> Subject: [EXTERNAL] Re: [GergelyTuri/tFC-rig] KeyboardInterrupt aka ctrl-c does not work during ITI (Issue #24)

Oh sorry didn’t see this. When I press ctrl c during a trial it only stops the data collection but not the arduino itself, which require me pressing the reset buttons on the boards to end the trial.

On Thu, Aug 8, 2024 at 5:48 PM Gergo @.<mailto:@.>> wrote:

@YuechengShi https://github.com/YuechengShi what's up with this?

— Reply to this email directly, view it on GitHub https://github.com/GergelyTuri/tFC-rig/issues/24#issuecomment-2276712649, or unsubscribe https://github.com/notifications/unsubscribe-auth/BB7NACOVMUXVFG4MGVSDS4DZQPRURAVCNFSM6AAAAABMHJ23JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZWG4YTENRUHE . You are receiving this because you were mentioned.Message ID: @.<mailto:@.>>

— Reply to this email directly, view it on GitHubhttps://github.com/GergelyTuri/tFC-rig/issues/24#issuecomment-2276735324, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEWM3TX6WU5P7NXXMEVXC2LZQPSRNAVCNFSM6AAAAABMHJ23JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZWG4ZTKMZSGQ. You are receiving this because you commented.Message ID: @.**@.>>

YuechengShi commented 1 month ago

I used ctrl c when we were running the serial read scripts directly through anaconda. The GUI has a button to stop collecting data and end trials now (which still requires me to manually reset both arduino boards).

On Thu, Aug 8, 2024 at 5:59 PM Gergo @.***> wrote:

How often do you need/use this functionality?

From: Yuecheng Shi @.> Sent: Thursday, August 8, 2024 5:57 PM To: GergelyTuri/tFC-rig @.> Cc: Turi, Gergely @.>; Comment @.> Subject: [EXTERNAL] Re: [GergelyTuri/tFC-rig] KeyboardInterrupt aka ctrl-c does not work during ITI (Issue #24)

Oh sorry didn’t see this. When I press ctrl c during a trial it only stops the data collection but not the arduino itself, which require me pressing the reset buttons on the boards to end the trial.

On Thu, Aug 8, 2024 at 5:48 PM Gergo @.<mailto:@.>> wrote:

@YuechengShi https://github.com/YuechengShi what's up with this?

— Reply to this email directly, view it on GitHub < https://github.com/GergelyTuri/tFC-rig/issues/24#issuecomment-2276712649>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/BB7NACOVMUXVFG4MGVSDS4DZQPRURAVCNFSM6AAAAABMHJ23JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZWG4YTENRUHE>

. You are receiving this because you were mentioned.Message ID: @.<mailto:@.>>

— Reply to this email directly, view it on GitHub< https://github.com/GergelyTuri/tFC-rig/issues/24#issuecomment-2276735324>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AEWM3TX6WU5P7NXXMEVXC2LZQPSRNAVCNFSM6AAAAABMHJ23JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZWG4ZTKMZSGQ>.

You are receiving this because you commented.Message ID: @.**@.>>

— Reply to this email directly, view it on GitHub https://github.com/GergelyTuri/tFC-rig/issues/24#issuecomment-2276738227, or unsubscribe https://github.com/notifications/unsubscribe-auth/BB7NACK23F33V4DBUNJTCJLZQPS3PAVCNFSM6AAAAABMHJ23JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZWG4ZTQMRSG4 . You are receiving this because you were mentioned.Message ID: @.***>