GeriLife / companionship

Promoting companionship and well-being for everyone.
European Union Public License 1.2
7 stars 18 forks source link

add development fixtures #104

Closed brylie closed 1 year ago

brylie commented 1 year ago

Task

brylie commented 1 year ago

@werberger, would you consider taking this task? Companionship Care is also a Django app, so it would be similar to the CiviWiki codebase. There are a few open tasks in Companionship Care, whereas most tasks in CiviWiki have been claimed.

werberger commented 1 year ago

I am definitely interested - the project looks amazing too. Thank you @brylie.

I will look at it in more detail over the coming days.

werberger commented 1 year ago

@brylie I've seen the factories defined in different places, where would you prefer them defined?

I think I'm confident resolving the issue just don't want to create more work for someone to move everything.

brylie commented 1 year ago

Let's start out with a factories.py in each app directory.

werberger commented 1 year ago

I've defined all factories for existing classes @brylie except for Activity which I'm struggling with due to it's ManyToMany relationship with User. I'm happy to keep working on it, but realise I've been assigned for some time. Understand if you'd prefer to move it on yourself. But happy to keep trying to work it out. Also open to any thoughts anyone might have. For the record, I have read this

brylie commented 1 year ago

Go ahead and split out the Activity factory into a follow-up task. Also, open a PR with the current factories.