GeriLife / companionship

Promoting companionship and well-being for everyone.
European Union Public License 1.2
7 stars 18 forks source link

Enable email verification for user registration methods #192

Open brylie opened 1 year ago

brylie commented 1 year ago

Users can register via the user interface or REST API. In both cases, we don't verify the user email, since we are still in beta.

When the time comes, we will use this task as a reminder to enable email verification.

### Tasks
- [ ] https://github.com/CompanionshipCare/companionship-care/issues/193
- [ ] https://github.com/CompanionshipCare/companionship-care/issues/194
ErnstBas commented 1 year ago

Hi @brylie I am new to contributing, but following this project and CiviWiki for some time. I would like to learn more about email verification. Could you assign this to me please?

brylie commented 1 year ago

Thanks, @ErnstBas.

The task is to follow the Django and AllAuth project documentation and add a verification email step when new users register. I can't specify how the exact code will look but can point toward the AllAuth related documentation.

We want to figure out how to verify user emails avter they register via either

ErnstBas commented 1 year ago

Thanks @brylie

brylie commented 1 year ago

If we get stuck on this issue, we can move on to other priorities. Email verification isn't essential right now.

The essential work is to implement REST CRUD endpoints for the main database entities.

ErnstBas commented 1 year ago

Not stuck yet, but not finished. I tried to work on #193 with Django-Verify-Email, but for some reason it continues to send invalid links (which is an unresolved issue I found later on their project page). I guess I have to figure out a custom solution linking the new user with a token. But I am happy to work on something else with a higher priority. And I would love to learn REST API. Which issue(s) would you suggest?

brylie commented 1 year ago

How about claiming this issue by adding a comment there

https://github.com/CompanionshipCare/companionship-care/issues/195

ErnstBas commented 1 year ago

195 seems to be assigned to @werberger. He is probably working on it already. #196 looks similar. If it's OK for you, I'll try that one.

brylie commented 1 year ago

Sure. Just add a comment in any available issue that you would like to take and I will assign you.