GeriLife / wellbeing-client

Client-only code for Wellbeing project.
Apache License 2.0
0 stars 0 forks source link

Rework authentication code to be more idiomatic #40

Closed brylie closed 3 years ago

brylie commented 3 years ago

Our authentication code is somewhat imperative, and relies on manually reloading the browser window:

This approach is leading to some bugs with deployment and development environments.

Re-work the authentication code so that it doesn't manually reload the window or mutate the window location.

For context, we are building a single-page app, so should not be refreshing the page. Similarly, the Vue router should be used for managing the window location.

See if there are other parts of the codebase where we are manually manipulating the window so we can deprecate that code.

Here is a good recipe to follow for the authentication code: https://www.digitalocean.com/community/tutorials/handling-authentication-in-vue-using-vuex