Gericom / GBARunner2

A GBA hypervisor for DS. (like nintendont for gc on wii)
745 stars 60 forks source link

Can't build on Linux because makefile has .exe in it #187

Closed lifehackerhansol closed 1 year ago

lifehackerhansol commented 3 years ago

The arm9 makefile tries to run arm-none-eabi-objcopy.exe.

Not a problem on Windows, but it's 100 percent going to fail anywhere else.

This small change made it build on Linux (in my case, Ubuntu 20.04 on WSL2), and it runs as expected.

lifehackerhansol commented 3 years ago

Force push was to change author email. Nothing else changed.

man-of-eel commented 3 years ago

Wouldn't this break it on Windows as well?

lifehackerhansol commented 3 years ago

Makefiles on other projects don't have it, so I don't see why it would break it here? If you have devkitARM properly installed there is 0 issue. I did test this with msys2 when I had it (but now I don't so I don't know how it would fare now)