search

GermaVinsmoke / bmi-calculator

React Hooks app for calculating BMI
https://germavinsmoke.github.io/bmi-calculator/
MIT License
200 stars 366 forks source link

Removing the MaterializeCSS dependency #1

Open GermaVinsmoke opened 4 years ago

GermaVinsmoke commented 4 years ago

There isn't much use of MaterializeCSS, so it's better to remove it.

Erick2280 commented 4 years ago

Hi! I'll take this issue :)

GermaVinsmoke commented 4 years ago

Alright, thanks for the help. I added travis ci for auto-deployment, I hope it'll help.

nuwan94 commented 4 years ago

Hi, Can I take this issue?

GermaVinsmoke commented 4 years ago

Yeah @nuwan94

CmdEngineer commented 4 years ago

@nuwan94 still on it? EDIT: If not can I take it?

GermaVinsmoke commented 4 years ago

Will it be better to use .css files or better go with styled-components?

CmdEngineer commented 4 years ago

I dont know

CmdEngineer commented 4 years ago

@nuwan94 still on it? EDIT: If not can I take it?

Still asking @nuwan94

GermaVinsmoke commented 4 years ago

Repo isn't even forked by him, so you can do it @CmdEngineer

CmdEngineer commented 4 years ago

Alright

CmdEngineer commented 4 years ago

@GermaVinsmoke Apparently MaterialCSS does have a big usage: image image

Buttons and the graph are unaffected

GermaVinsmoke commented 4 years ago

The main thing is materialize-css grid - className="container" className="row" className="col " I think we can use flexbox instead of this. A lot of things will be solved with the help of flexbox.

The other thing is className="card". So, for this, I think it'll be better to use styled-components coz reusable Card component.

Removing materialize-css as it is having some security issues and I think we don't need it as it is having a size of 175kB (minified) and styled-components is having a size of 45kB (minified).

CmdEngineer commented 4 years ago

materialize-css as it is having some security issues how does css introduce security issues?

CmdEngineer commented 4 years ago

Suggestion: maybe use Spectre?

GermaVinsmoke commented 4 years ago

materialize-css as it is having some security issues how does css introduce security issues?

Three of its javascript component are having vulnerabilities and there's no patch fix for that 🤔. So, if we're not using any of the JS Components then why to keep a module of that big size. I think that Spectre.css is cool and it'll work.

mat