search

German-Cobian / Top-Ranks

A javascript app where users can input their name and purported current score. It calls an API where said information is saved, for this user and for whatever other users may tap into it.
MIT License
5 stars 0 forks source link

P2P Code Review (Oct-12-2021) #4

Open AlexHamn opened 2 years ago

AlexHamn commented 2 years ago

Great job so far! Your code is very clean and readable, keep it up 👍

lfmnovaes commented 2 years ago

Great project German 💪

I have one small suggestion that makes sense for an actual leaderboard, and that would be to sort your scoreList by score before creating the list, in this line: https://github.com/German-Cobian/Top-Ranks/blob/8108512e9edf5bdbd34082e6900e5cd4f665368a/src/modules/createList.js#L4 You can place something like this: scoreList.sort((a, b) => b.score - a.score); before this line above.

That's it, keep up with the great work. 🙌

peterdgreat commented 2 years ago

Great Project

However, I think it will be nice if you can add a validation to the form concerning the max number of user value input to the score.