search

GermanBread / declarative-flatpak

126 stars 4 forks source link

Option to disable warnings #7

Closed crabdancing closed 10 months ago

crabdancing commented 1 year ago

I find that modules that show warnings even when the system is in a good state, train me to ignore red text during build. This makes it easy to miss new, important warnings. Including an option to disable the warnings would be nice.

GermanBread commented 1 year ago

Hi, which warnings are you talking about? The ones present in the stable branch or the dev branch?

The warning in the stable branch was put in place to notify the user of a big change and to pin their flatpak module input.

The warning in the dev branch was put in place to notify the user of a major change.

This makes it easy to miss new, important warnings.

Imo I think the warnings I put in place are already important.

crabdancing commented 1 year ago

Oh, no, I'm not saying they aren't important! It's just that importance is contingent on what the user is already aware of. The warnings are important to see & make note of -- but then they become less important once the user is made aware of them. From a UX perspective, I think it's best practice to allow permanent dismissal of warnings the user is already aware of -- otherwise they might see the red color and absentmindedly ignore it, when it's actually a different warning.

As for which warning, I'm on stable right now, as I had some issues with the dev branch -- but I feel like this concern applies to both.