search

GermanBread / declarative-flatpak

127 stars 4 forks source link

Allow disabling warning, and prevent module from bricking nixosConfigurations that don't make use of it #8

Closed crabdancing closed 1 year ago

crabdancing commented 1 year ago

Fixes #6 and #7 for dev branch

GermanBread commented 1 year ago

About the assertion: I was thinking of disabling the entire module when services.flatpak.enable = false;

I'm actually writing tests right now.

crabdancing commented 1 year ago

Oh, I already did that in the PR! :P Looks like I missed home-manager module tho. Whoops.

Regardless, I think it's a pretty ergonomic solution that I can't imagine causing any problems. :3

crabdancing commented 1 year ago

Actually... I think it might be better to have a separate option for enabling or disabling this specific module. Reason being, that if you have a lot of systems, you might want to disable 'declarative flatpaks' on some, while still enabling flatpak itself as a service.

E.g., I am maintaining computers for multiple people, and some might want to use the Discover store or something to install some packages instead of experiencing the true power of Nix.

I may not approve of their imperative lifestyle, but I'll pray for them. :pray: And try to accommodate them in system design. :P