search

GermanCoding / Roundcube_TLS_Icon

Roundcube plugin that displays a lock icon next to the subject line, showing the encryption state of an inbound mail
Other
9 stars 4 forks source link

Documentation wrong word #21

Open williamdes opened 1 year ago

williamdes commented 1 year ago

https://github.com/GermanCoding/Roundcube_TLS_Icon/blob/4b1fb861bbcfa47303e58f44972f7c48fc72d0f1/config.inc.php.dist#L9

Reading the code: https://github.com/GermanCoding/Roundcube_TLS_Icon/blob/4b1fb861bbcfa47303e58f44972f7c48fc72d0f1/tls_icon.php#L34

it should be uses the first Received-Header

Do you agree ?

GermanCoding commented 1 year ago

It's probably a matter of perspective.

From a network point of view, the "last header" means "the header from the last hop", which is what is meant here.

From a file-point of view, SMTP appends Received-Headers at the top, so the last header to be inserted is at the top, which is the first one in the file.

williamdes commented 1 year ago

And from what I understand, reading: https://github.com/GermanCoding/Roundcube_TLS_Icon/blob/4b1fb861bbcfa47303e58f44972f7c48fc72d0f1/tls_icon.php#L32

I think we should make clear that the value of tls_icon_ignore_hops is not the number of hops to skip, but the number of the hop to use. I can not make this plugin work for me, still need to debug :/

williamdes commented 1 year ago

It's probably a matter of perspective.

From a network point of view, the "last header" means "the header from the last hop", which is what is meant here.

From a file-point of view, SMTP appends Received-Headers at the top, so the last header to be inserted is at the top, which is the first one in the file.

Maybe we could make the wording a bit more clear then ?

GermanCoding commented 1 year ago

Yeah, could be more clear