Make a few more facts derived (this caused some changes because as usual this changes rounding)
Switch one fact to another one (Fact_B_P_plumbing_ratio_wage_to_main_revenue_2017 -> Fact_B_P_renovations_ratio_wage_to_main_revenue_2017 both model roughly the same thing, value is not exactly the same but the ballpark is the same and this is used for very very rough guesses anyway.
Change the API to require the reference year year_ref (one of 2018 or 2021).
Change the command line tools to accept a flag -year_ref default is 2018 for now.
Change the end to end tests so that they exist twice, once for 2018 and once for 2021
For now the test code skips running for 2021.
Ready to rock
Note that here we are skipping the 2021 end to end tests (for now).
(.venv) benediktgrundmann@Benedikts-Air localzero-generator-core % python devtool.py ready_to_rock
WARNING: there is a new pyright version available (v1.1.301 -> v1.1.350).
Please install the new version or set PYRIGHT_PYTHON_FORCE_VERSION to `latest`
No configuration file found.
pyproject.toml file found at /Users/benediktgrundmann/Programming/localzero/localzero-generator-core.
Loading pyproject.toml file at /Users/benediktgrundmann/Programming/localzero/localzero-generator-core/pyproject.toml
Assuming Python platform Darwin
Auto-excluding **/node_modules
Auto-excluding **/__pycache__
Auto-excluding **/.*
Searching for source files
Found 201 source files
pyright 1.1.301
0 errors, 0 warnings, 0 informations
Completed in 2.399sec
=========================================================== test session starts ===========================================================
platform darwin -- Python 3.10.12, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /Users/benediktgrundmann/Programming/localzero/localzero-generator-core
plugins: anyio-3.6.2, cov-3.0.0
collected 45 items
tests/test_devtool_commands.py .............. [ 31%]
tests/test_end_to_end.py ......s.s.s.s.s.s [ 68%]
tests/test_entries.py . [ 71%]
tests/test_refdata.py .... [ 80%]
tests/test_tracing.py ......... [100%]
====================================================== 39 passed, 6 skipped in 5.53s ======================================================
Trim Trailing Whitespace.................................................Passed
Mixed line ending........................................................Passed
Check for case conflicts.................................................Passed
Check Yaml...............................................................Passed
Check for added large files..............................................Passed
Don't commit to branch...................................................Passed
black....................................................................Passed
You are ready to rock and save the climate at 2f70d5ae385160fd9dfb65dcdcd71a138501618d, but don't forget to copy paste the above into your pull request
This does a bunch of things:
Fact_B_P_plumbing_ratio_wage_to_main_revenue_2017 -> Fact_B_P_renovations_ratio_wage_to_main_revenue_2017both model roughly the same thing, value is not exactly the same but the ballpark is the same and this is used for very very rough guesses anyway.year_ref(one of2018or2021).-year_refdefault is2018for now.2018and once for20212021.Ready to rock
Note that here we are skipping the 2021 end to end tests (for now).