Germandrummer92 / TalkingRobot

PSE
0 stars 0 forks source link

<> in NLG #10

Closed narigaoka closed 10 years ago

narigaoka commented 10 years ago

sometimes the words which were given by the DialogStates don't get exchanged. Like for the ChoiceStrategy this happens:

Your next Input:cantaan

, // the return-value of dmResult.getOutputKeyword() dm.ErrorHandlingState The robot says: Do you mean <1> or <2> ? and also the wrapping signs {} sometimes don't get exchanged/deleted.
luizhsilva commented 10 years ago

I'll check that.

Germandrummer92 commented 10 years ago

Another instance of wrongly formatted output:

Input after login:

how do you make a hamburger

Expected Output: how do you make a hamburger Keyword 0: how do you make Keyword 1: hamburger dm.RecipeAssistanceState The robot says: To prepare this recipe you will need the following ingredients and tools Ground beef. Lettuce. Buns. Knife When you have them follow the following steps Form the ground Beef into hamburgers Grill the burgers till medium rare Cut up the rest of the needed ingredients Cut up the bun Real Output: how do you make a hamburger Keyword 0: how do you make Keyword 1: hamburger dm.RecipeAssistanceState The robot says: To prepare this recipe you will need the following ingredients and tools Ground beef. When you have them follow the following steps knife> {Form the ground Beef into hamburgers Grill the burgers till medium rare Cut up the rest of the needed ingredients Cut up the bun

Apparently it has problems it more than one string is passed for something

luizhsilva commented 10 years ago

The problem is because the output should be like < object >,{complement} but right now in some states is "< object > {complement}". Without the comma, and with a space. I'll change the *States and see if it works. In the ErrorHandling the problem is that the NLG wasn't expecting to read < 1 > or < 2 > (or even a third one! <3>) only < o > or {c}, and we didn't know that, so now I'll change it so it does expect these.

narigaoka commented 10 years ago

oh, i actually already discussed this with xizhe. if it is more comfortable for you, i can change it in the ErrorHandlingState to a format which suits you better

luizhsilva commented 10 years ago

I'm changing already. I think it is fine to leave it like this. If I have any complicated trouble I tell you.

luizhsilva commented 10 years ago

Ok, that with the ErrorHandling should be fixed. Now the thing with the recipe. (I'll need to modify many State classes, like RecipeLearningState, KitchenAssistanceState, etc. I hope no one is modifying them =) ).

luizhsilva commented 10 years ago

Ok, so now I hope these issues were fixed =/ If not, please reopen!! I had to make a change in RecipeAssistanceState, in the way the tools and ingredients are given as a string, when they are separated with commas. Now they are just separated with a normal blank space, in order not to get the NLG confused. If it's really necessary to keep them with commas, then I would have to make some changes in the outputCreator. So please tell me.