search

Germandrummer92 / TalkingRobot

PSE
0 stars 0 forks source link

CR: NullpointerException after giving my preference #14

Closed rosine closed 10 years ago

rosine commented 10 years ago

input after being asked for preference: chicken

output: NullPointerException at nlg.OutputCreator.addSocialComponent(OutputCreator.java:217)

luizhsilva commented 10 years ago

-.- I think is something I just did. Because it was working before... and it works if your preference is pork. Checking checking!

luizhsilva commented 10 years ago

Ok, i THINK I fixed it ^^. I still have to fix some other things in CR! More importantly the changing of states after you're finished, or if the meal is not found. You can try some more times too, and if it's ok, you can close it.

luizhsilva commented 10 years ago

BTW, chicken is not a valid category... if we are planning to use the categories given from the canteen... as well as "beef" (it should be cow)

rosine commented 10 years ago

about the categories. should we add "cow" as keyword then?

luizhsilva commented 10 years ago

I guess so... because that's what's checked within the CanteenData...

narigaoka commented 10 years ago

cow was added. though, i think, the dm should be able to work with beef, too, because people usually wouldn't say: "i want to eat something containing cows", i think "i want to eat something containing beef" is more common ... so beef should also be recognized as an equivalent to "cow" in the canteen-dialogs

luizhsilva commented 10 years ago

hmmm, yes, I can modify the Dialog to understanding beef as cow.

rosine commented 10 years ago

ok, I added "cow" and "cows" (and a few others) in the grammar but they still need to be added as keywords

luizhsilva commented 10 years ago

And I don't know if it really makes sense to also add chicken, because the canteen data we get from studentenwerk doesn't have chicken, so I cannot search for it there. It would always go to MEAL_NOT_FOUND =/

luizhsilva commented 10 years ago

Well, I guess the NullPointerException problem should be fixed? so I'll close the topic. If it happens again someone can open it!