Germandrummer92 / TalkingRobot

PSE
0 stars 0 forks source link

When entering a recipe and entering an already known country of origin, the robot switches to RecipeAssistance. Also error in output. #3

Closed Germandrummer92 closed 10 years ago

Germandrummer92 commented 10 years ago

To reproduce:

input after login:

teach you spaghetti bolognese italy

real output:

. what is the recipe called . from what country does this recipe come from Now I'm working as a recipe Assistance

expected output: what is the recipe called from what country does this recipe come from tell me the first ingredient

alexaand commented 10 years ago

I know about this problem and think it is mainly due to the keywords (point only to recipe assistance), but i will try to fix this after the exam :D

narigaoka commented 10 years ago

i have modified the keyword-data for "britain", "italy" & "spain" (165-167) and it should work now for these. i'm not sure if there are more country-kw-datas so far ...

narigaoka commented 10 years ago

but i believe there are some problems when we create new country-kw-datas in RecipeLearningDialog from line 322:

RecipeAssistanceState(RecipeAssistance.RA_TELL_COUNTRY_OF_ORIGIN));

i guess, this is also what Bettina asked in the other topic. Countries should actually already point at RL_ASK_FIRST_INGEDIENT , isn't it? At least this worked for the keywords 165-167

alexaand commented 10 years ago

Yes they should when it works for these three. But if we want to answer questions like tell me an recipe from italy, they should also point to recipe assistance, although I am not entirely sure if we are going to implement this ...

alexaand commented 10 years ago

Now i have implemented it so, that it is all the same where the countries point to, if we are in ask_country_of_origin and there is at least one country in the keywords, so this country is accepted as the country of origin. It still might be a good idea that they point to somewhere in RecipeAssistance (as i said when the user asks for recipes from a particular country).