search

Germandrummer92 / TalkingRobot

PSE
0 stars 0 forks source link

When entering KitchenAssistance, nullPointerException in OutputCreator occurs. #7

Closed Germandrummer92 closed 10 years ago

Germandrummer92 commented 10 years ago

Input after login: where is tomato

Expected Output:

Real Output: NullPointerException in OutputCreator.findInFile
luizhsilva commented 10 years ago

Checking this issue now.

luizhsilva commented 10 years ago

Ok, this is happening because: 1. "where is tomato" is leading to CanteenInformation, which is not the right State, right? 2. In CanteenInformation someone added a new state called CI_LINE_LOCATION_INFO and forgot to add it in the sentences.json file... so since the State is not found, it tries to get the size of a null array, which leads to NullPointerException.

I could handle this java exception, but we're not supposed to expect States that don't exist... I can add this state to the sentences.json, but "where is tomato" is still leading to a wrong state =( maybe "tomato" should have a bigger priority than "where" ?

narigaoka commented 10 years ago

oh, i have added the CI_LINE_LOCATION_INFO. because the user could ask "where is line one" or something similar. So I thought, we'd need this.

luizhsilva commented 10 years ago

It's fine =D So, should I change the "tomato" priority? and the other ingredients priority? Because I think the "where" is leading it to the CanteenInformation...

luizhsilva commented 10 years ago

Hmm, I changed, but then now it goes to RecipeLearningState... too many states, so it goes always to the first, when in fact it's not what we want.

narigaoka commented 10 years ago

maybe we should change the keyword data "where"? and add kitchen_assistance? "where" and its equivalents probably only lead to CI. If both "where" and "tomato" point at KA, it should lead to Kitchen Assistance, shouldn't it?

luizhsilva commented 10 years ago

now there's the keyword "where is", which also leads to CI. And I tried to add the reference to KA, but it still doesn't work. Right now it doesn't throw an exception, but it goes to CI and the robot doesn't say anything.

Germandrummer92 commented 10 years ago

I edited where is to fix this