search

Gernott / mask

TYPO3 Extension Mask
https://www.facebook.com/typo3mask
GNU General Public License v2.0
131 stars 86 forks source link

original IRRE fields are shown in translation even if fields were translated already #442

Closed medarob closed 3 years ago

medarob commented 3 years ago

I noticed something with one of our banner elements where we use Mask, found a 'workaround' and I wanted to let you know because I don't know if this is a bug.

I have a banner element with 3 slides (German, dummy language which is disabled in FE) and wanted to localize the banner (English). German: grafik

Then I localized the banner element and got this: English: grafik

136 => 816 137 => 817 795 => 818

It shows the German records 136 and 137 twice. One time localized and the other one is disabled. There is the "Alle Datensätze lokalisieren" Button but when I click it, nothing happens. I assume that's because there are non localized elements shown which were already localized and therefore the button has no function.

This seems to only effect old IRRE elements. The slide "Test" (795) was added later (under a newer Mask version) and this one is not available a second time.

I looked in the DB and found this differences:

grafik

It seems that sys_language_uid is -1 for both older slides which appear twice. Also, l10n_parent is 0 for the new localized slides but it is available for the new "Test" slide.

If I change sys_language_uid to 0 (in the BE) the slides don't appear a second time (after a new localization). The "Alle Datensätze lokalisieren" button is also not available anymore because everything was localized.

My question: Do I have to set the sys_language_uid for old IRRE elements (maybe other elements aswell) to 0 so that those elements won't appear a second time or is this a Mask bug?

Currently I us Mask 7.0.27 and TYPO3 10.4.21.

nhovratov commented 3 years ago

Hey, thanks for the detailed report. First of all, this is TYPO3 related. It seems to happen, if the source language is ALL (-1) and then translating it to another language. Maybe it would be better to report it on forge.typo3.org? There we can have a few more opinions. To me, it doesn't seem right, too. Records with language ALL aren't supposed to be translated and shouldn't appear as untranslated records.

My advise is to avoid using language ALL and use your default language instead.

I close this, as it's not a Mask bug. Would be cool, if you copy this to forge. At a first glance I couldn't find a duplicate issue.

medarob commented 3 years ago

Thank you for your feedback. I created an issue on forge: https://forge.typo3.org/issues/95918