Gernott / mask

TYPO3 Extension Mask
https://www.facebook.com/typo3mask
GNU General Public License v2.0
128 stars 85 forks source link

Mask FontAwesome Icons missing in NewContentElementWizard #551

Open nhovratov opened 1 year ago

nhovratov commented 1 year ago

TYPO3 v12 / Mask v8.1

mask-fa-icon

nhovratov commented 1 year ago

See: https://forge.typo3.org/issues/100901

stephangrass commented 1 year ago

Are there any updates on this topic?

nhovratov commented 1 year ago

No, not really. I would recommend to use SVG icons directly.

ursbraem commented 11 months ago

Does it make sense to +1 at https://forge.typo3.org/issues/100901 ?

ursbraem commented 11 months ago

Also, maybe it's possible to additionally load FontAwesome directly from Mask or Sitepackage for the time being? Not?

nhovratov commented 11 months ago

The problem is, that the CSS is not applied anymore in the New Content Element Wizard, as it is now a Web Component. There is no workaround for Mask. I don't know if someone is willing to spend time investigating the issue in the Core.

ursbraem commented 11 months ago

About the SVG icons: they have to be wired via TS right? That's a bit tedious. Would it be future proof(er) to disable the FA selector entirely and replace it by a Field in the module?

nhovratov commented 11 months ago

You can put an SVG file with the Content Element name in a folder and it will be loaded automatically: https://docs.typo3.org/p/mask/mask/8.3/en-us/BackendPreview/Index.html#preview-image-for-a-content-element

ursbraem commented 11 months ago

Woot! That's great news. So I think we'll switch to that with every v12 site

vitamys commented 11 months ago

I added the svg icons as described (in the EXT:{your_sitepackage}/Resources/Public/Mask). However, they are still not displayed in the new content element wizard. They show up only in the page module.

image image
nhovratov commented 11 months ago

@vitamys Maybe cache? Could you try to clear all browser cache + local Storage ?

vitamys commented 11 months ago

clearing the local Storage did the trick! Thank you!

cyril392 commented 6 months ago

Hello, I have the same problem (TYPO3 v12 and Mask 8.3.10). I've tried as described here and in the docs but I can't get my icon. Should we keep the fontAwesome icon definition in the mask.json? Should the files in the svg folder have specific rights? When you say the name of the content, is it the name (YouTube & Vimeo) or the key (youtube_vimeo) in your example? I've tried clearing all my caches but nothing changes. In my example I have the content "Accordion box" with the key "accordion_box". So what would the name of my file be? Thanks in advance

nhovratov commented 6 months ago

Should we keep the fontAwesome icon definition in the mask.json?

You can keep it, but it will do nothing. In the next Mask version, the Icon Picker will vanish completely.

Should the files in the svg folder have specific rights?

no, just the default rights for public files.

So what would the name of my file be?

It would simply be accordion_box.svg

cyril392 commented 6 months ago

Thank you for your reply! In the end it's the content key and in fact I was emptying the caches but not the local storage and that was the problem...