Gernott / mask

TYPO3 Extension Mask
https://www.facebook.com/typo3mask
GNU General Public License v2.0
130 stars 86 forks source link

Remove duplicated element-label in TYPO3 v12 page module #557

Closed peter-neumann-dev closed 1 year ago

peter-neumann-dev commented 1 year ago

The new page module introduced in TYPO3 v12 adds the header and subheader of an element by default above the backend preview template. Mask adds the label of the element before the backend preview template, but after the header. This is interrupting the content flow between headers and body of an element. Especially for Text or Text-Image elements.

Peter Neumann 2023-05-30 at 16 07 49

Since the new TYPO3 page module in v12 shows the label of an element by itself above the headers, I would suggest removing label from Mask for TYPO3 v12:

Peter Neumann 2023-05-30 at 16 18 55

For TYPO3 v11 the label was nice to have and also not interrupting because we rendered the headers inside the preview template. If possible, it could stay for ≤ v11.

nhovratov commented 1 year ago

Hi, thanks for the issue reporting!

You are right, the element name is now shown twice. This is actually because it is no more possible to override the header part of the backend preview, as it was before with the old hook. This was handy, as some people don't define the header field for their element and so this could be used as a link. The standard header is not linked unfortunately.

I have nothing against removing it. People should care for their backend previews better then.

peter-neumann-dev commented 1 year ago

Sounds plausible. 👍 Anyhow, since TYPO3 the standard header is now linked by default

nhovratov commented 1 year ago

Actually it was also rendered in TYPO3 v11 by default, but Mask overrides this with its Element label.

peter-neumann-dev commented 1 year ago

Okay I understand 😃