Gerold55 / WasteLands_Survival

An apocalyptic based game for MT.
Other
2 stars 10 forks source link

Group update and various small fixes #45

Closed Skamiz closed 4 years ago

Skamiz commented 4 years ago

~Changes drops so that you don't get whole bone blocks when diging in dirt. Bone shards drop instead.~ ~Updates a few recipes to use groups instead of specific nodes.~ Updates ruins decorations to use replacements, so they spawn with the correct node ids. Removes some dead code. ~Rebalances groups.~

NO LONGER APPLIES:

IMPORTANT I made a change which may be controversial, by changing a convention used in default. In default, nodes which are HARDER to break have a LOWER group value. Example: obsidian has 'cracky = 1' glass has 'cracky = 3'

This always struck me as un-intuitive because: 1) What are they going to do if someone wants to add a node which takes even longer to mine than obsidian? They basicaly put a limmit on increasing digging times, but left open the option to add shorter digging times. 2) This results in odd tool registrations Example: stone pick has these digtimes 'cracky = {times={[2]=2.0, [3]=1.00}},'

Notice that it can only dig nodes which have cracky group 2 or 3. This feels odd to me since I intuitively expect that if a tool can dig nodes of a certain hardness it can also dig all nodes of a lower hardnes. With the 'default' convention these numbers are surounded on both sides by unknowns.

What I did my my code is the reverse. Nodes which are the fastes to dig have a group value of 1. Then, nodes which are supposed to take longer to dig, use a progresively higher group value.

And finaly just to clarify something, because how tools work is honestly kind of cunfusing. The value of a group of a node has NO influence on how fast it is mined or if it even can be mined at all. It depends COMPLETELY on the groupcaps defined by the tool.

Example: cracky = {times={[42]=1.00, [13]=5.00, [76]=2.00}},

A tool with these parameters can only dig nodes which have the cracky group AND ONLY THEN if thier cracky group has a value or 42 or 13 or 76. No others! Additionaly thier dig times deppend entirely on the TIMES defined in the tools capabilities. NOT ON THE VALUE OF THE GROUP. What I am saying is: If dig times increase or decrease with an increasing group value is a mater of convention not a hard rule. And I choose to use the convention which makes more sense to me.

Hope this isn't too confusing. If it is, please ask me to elaborate.

Skamiz commented 4 years ago

Never done this before, but I think I reverted the changes to the groups.

Wizzerinus commented 4 years ago

Yeah, now this should work