search

Gerold55 / laptop

Introducing the MineTest Laptop Mod
Other
26 stars 14 forks source link

Grizzly-Adam themes revision #101

Closed bell07 closed 6 years ago

bell07 commented 6 years ago

Follow-up pull request replacing #98 and #100

Grizzly-Adam commented 6 years ago

If I am reading this right you are removing desktop_icon_label_button, exit_character and titlebar_textcolor???

I see I accidentally left the get_blacktext function in there. We fixed that issue so that is garbage.

bell07 commented 6 years ago

I just changed the order in "Freedom" theme and in API.md

Grizzly-Adam commented 6 years ago

Oh OK. Because we have themes using them :)

bell07 commented 6 years ago

I am unhappy with Freedom as default. It should be an simple theme with less overrides in other themes. But this is maybe an other pull

Grizzly-Adam commented 6 years ago

Everything else looked good from what I could tell. And those background images-- are they mine? I spent about an hour reducing the size of all of them through limiting the pallets so the game loads faster.

bell07 commented 6 years ago

I did not touched the images, just squashed all "delete file" and "add file" commits into one. But double-check it, maybe anything goes wrong with git

Grizzly-Adam commented 6 years ago

OK, looks like theme. I'm going to take it for a spin around the block.

Grizzly-Adam commented 6 years ago

It all looks good from here. I just ran through every theme. I think it is ready.

bell07 commented 6 years ago

Should I click to "Merge pull request"?

Grizzly-Adam commented 6 years ago

I believe so.

bell07 commented 6 years ago

Thank you for the great work!

Grizzly-Adam commented 6 years ago

Same to you. I am starting to understand you computers a bit better.