Themes

[Gerold55]

Should we be able to make the icons customizable like the other things of the theme?

Last-To-Do List

• [x] for chest game we can set os_min_version to a value higher then the monochrome versions.
• [x] All other themes needs to be tested and adjusted for new parameters.
• [x] I try to merge our and my branch, then I add "monochrome" parameter and adjust tetris to colorize all by the cs-bos console textcolor in this case
  • [x] replace default_diamond_block.png in tetris app by own "gray" texture
• [x] Please change/rename also theme.bgcolor2 to something prefixed (theme.second_bgcolor ?)- EDIT: they are textures, so name both bgcolor to _background. bgcolor is reserved for rgb-values
  • [x] adjust default bgcolor rgb values and port more unicolor textures to mtos.theme:get_bgcolor_box()
  • [x] Check texture filename prefixes for "laptop_*.png". Check unused textures could be deleted
  • [x] Check/Update API.md documentation
  • [x] Check/Update the README.md
  • [x] Clarify if tty_monochrome should be setteable by theme (ember and green theme)

[bell07]

Tried to replace the "bgcolor1" image by mtos.theme:get_bgcolor_box('8,1.55;6.9,7.2', "table").. Does not work for amber theme and I do not have an idea why :-(

By the way, the Amber theme is not used in this mod. Can we setup the green and amber theme to be useable up to 5.50 version? So the themes will be selectable for nostaliga fans on "cube" and "portable workstation"?

[Grizzly-Adam]

Amber theme is used for computers who's monitors are only amber, same with the green theme. If we want to allow it to work on 5.50 it will mean chess needs min version of 5.51. I will have to monochrome the setting icon too (not a big deal). It can be done if that's what you want. I'm ok either way.

[Grizzly-Adam]

I am really happy with how the tetris texture turned out. Looks good in amber, green and in color.

[Grizzly-Adam]

@bell07 re: Please change/rename also theme.bgcolor2 to something prefixed (theme.second_bgcolor ?)- EDIT: they are textures, so name both bgcolor to _background. bgcolor is reserved for rgb-values

How about theme.background and theme.alt_background. And you are the one who named the bgcolor to begin with :P

[Grizzly-Adam]

I looked all the themes over, made some adjustments (mainly to table colors and textcolor). Amber theme is complete, green theme is now done as well. Improved background on CS-BOS Shell theme. Made all shell themes max_os_version 5.5 max, chess 5.51 min.

@bell07 I think it is just the bottom three items left on your checklist.

[Grizzly-Adam]

@Gerold55 Here is my attempt at sprucing up the printer screen. Looking for input.

[Gerold55]

Looks pretty good 👍 On Mar 17, 2018 6:54 PM, "Grizzly Adam" notifications@github.com wrote:

@Gerold55 https://github.com/gerold55 Here is my attempt at sprucing up the printer screen. Looking for input.

[image: screenshot from 2018-03-17 17-46-35] https://user-images.githubusercontent.com/35204361/37560752-35a23b40-2a0c-11e8-8b23-8cce15e5e0fd.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/102#issuecomment-373958885, or mute the thread https://github.com/notifications/unsubscribe-auth/ANM6l5dZIkjFo3-iZbx4T4dEa_4k2JrLks5tfZQagaJpZM4SSiUn .

[bell07]

How about theme.background and theme.alt_background. And you are the one who named the bgcolor to begin with :P

I see we are confused both on the lot of new settings :P Let consolidate the existing prefixes:

desktop - Launcher Setting (Background only) desktop_icon - Background for app icon in launcher desktop_icon_label - THe label under app icon in launcher app - setting for App Window (Background) titlebar - The title bar in App window back - App window back button exit - App window Exit button major - Highlighted (Button) minor - Not highlighted (Button) muted - ?? contrast - Dark area under not themeable elements table - Table colorizing table_highlight - "The green bar" - highlighted table colorizing status_online - "green" status_disabled - "yellow" status_off - "red"

Do you see prefixes we can consolidate? Maybe app, major, minor or muted could be re-used?

I think "Label-Textarea" shoud be themed in same way as the table. So the bgcolor1 is "table_background" (The background image is the same color as table_bgcolor RGB value)

What is the reason for bgcolor2? Do we need new "alt" prefix or we can re-use existing one?

[Grizzly-Adam]

Looks in the mail app for the use of bgclolr2 (now alt_background). I needed two background colors in there-- I think it was for the right "message" payne.

On Mon, Mar 19, 2018 at 2:21 AM, bell07 notifications@github.com wrote:

How about theme.background and theme.alt_background. And you are the one who named the bgcolor to begin with :P

I see we are confused both on the lot of new settings :P Let consolidate the existing prefixes:

desktop - Launcher Setting (Background only) desktop_icon - Background for app icon in launcher desktop_icon_label - THe label under app icon in launcher app - setting for App Window (Background) titlebar - The title bar in App window back - App window back button exit - App window Exit button major - Highlighted (Button) minor - Not highlighted (Button) muted - ?? contrast - Dark area under not themeable elements table - Table colorizing table_highlight - "The green bar" - highlighted table colorizing status_online - "green" status_disabled - "yellow" status_off - "red"

Do you see prefixes we can consolidate? Maybe app, major, minor or muted could be re-used?

I think "Label-Textarea" shoud be themed in same way as the table. So the bgcolor1 is "table_background" (The background image is the same color as table_bgcolor RGB value)

What is the reason for bgcolor2? Do we need new "alt" prefix or we can re-use existing one?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/102#issuecomment-374121453, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCaXvc-dvsxnsMImF5_wg8NYgY8K0ks5tf1x8gaJpZM4SSiUn .

[bell07]

I see some textures are named wrong. All textures needs to be named "laptop_" to avoid overwrites by other mods. printer_button.png printer_button1.png (unused?) printer_printed.png (unused?) tetris_block.png

I looked all the themes over, made some adjustments (mainly to table colors and textcolor).

Can you please push the changes for review?

I checked the PNG-files, the next of them seems to be not used: laptop_calendar.png laptop_email_letter_new.png laptop_email_trash_B.png laptop_m_bios.png laptop_manual.png laptop_theme_ambershell_mail.png laptop_theme_greenshell_mail.png laptop_txt_document.png printer_button1.png printer_printed.png

[Grizzly-Adam]

I will double check all these files tonight and send the push.

On Mon, Mar 19, 2018 at 12:16 PM, bell07 notifications@github.com wrote:

I see some textures are named wrong. All textures needs to be named "laptop_" to avoid overwrites by other mods. printer_button.png printer_button1.png (unused?) printer_printed.png (unused?) tetris_block.png

I looked all the themes over, made some adjustments (mainly to table colors and textcolor).

Can you please push the changes for review?

I checked the PNG-files, the next of them seems to be not used: laptop_calendar.png laptop_email_letter_new.png laptop_email_trash_B.png laptop_m_bios.png laptop_manual.png laptop_theme_ambershell_mail.png laptop_theme_greenshell_mail.png laptop_txt_document.png printer_button1.png printer_printed.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/102#issuecomment-374293360, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCTNlaUEvcM_PO2SOg-rZqFV5J0Yrks5tf-f7gaJpZM4SSiUn .

[Grizzly-Adam]

I deleted all the mentions files from my install and found no issue. Lets hang onto calendar, bios, manual, and text document (maybe place them in their own repository or something) because we will probably use them later.

Renamed tetris_block.png and printer_button.png. Updated tetris & mail apps, full colour, amber and green shell themes to reflect these changes.

Update pushed.

[bell07]

Thank you! I checked all and seems to be fine.

About tetris monochrome theming: I tired the ember theme on CUBE since it is selectable. In tetris the blocks are colorized, because the "tty_monochrome" setting is set in OS version and HW-node, the Cube both does not match. What do you think, should be the "tty_monochrome" setteable on theme too? So tetris will be monochrome on "more modern" devices if ember or green theme selected. (I vote for yes, can do it in evening)

Created new branch to store unused textures: https://github.com/Gerold55/minetest-laptop/tree/unused_textures

The last point is to check README, and API doc if all new things are mentioned. I do rewrite the theming documentation in API, grouped by prefixes in evening

[Grizzly-Adam]

Yes, theme should set tty to make sure our apps all looks the way we intend them to.

On Tue, Mar 20, 2018 at 2:48 AM, bell07 notifications@github.com wrote:

Thank you! I checked all and seems to be fine.

About tetris monochrome theming: I tired the ember theme on CUBE since it is selectable. In tetris the blocks are colorized, because the "tty_monochrome" setting is set in OS version and HW-node, the Cube both does not match. What do you think, should be the "tty_monochrome" setteable on theme too? So tetris will be monochrome on "more modern" devices if ember or green theme selected. (I vote for yes, can do it in evening)

Created new branch to store unused textures: https://github.com/Gerold55/minetest-laptop/tree/unused_textures

The last point is to check README, and API doc if all new things are mentioned. I do rewrite the theming documentation in API, grouped by prefixes in evening

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/102#issuecomment-374504846, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCepAjkbCn60Qcw8EsyMnR9VRV1aHks5tgLRHgaJpZM4SSiUn .

[Grizzly-Adam]

The more I thinl about it the better setting tty through theme sounds. It will mean color is no longer tied to os version and we can make any old computer amber, green, or full color regardless of version.

I looked at the reqdme last night and didnt find anything that needed updating.

[bell07]

Note we have 2x tty settings:

1. tty_textcolor - Initially OS-version dependant, but can be set differ for each hardware ("AMBER", "GREEN", "WHITE")
   2. tty_monochrome - Boolean setting if the colors could be changed or not. Used in CS-BOS to disable "TEXTCOLOR" command, and in tetris-app to disable blocks colorizing.

I had the idea to merge tty_textcolor with themes "table_textcolor". But the tty_textcolor value is not RGB and needs to be supported by CS-BOS "TEXTCOLOR" command.

I am about tty_monochrome setting. In CS-BOS the OS-Version and HW setting still should be used, for tetris app the setting should be used from theme ("optimized for monochrome")

[bell07]

Introduced theme.monochrome_textcolor is set in both monochrome themes and used in tetris app. This attribute means "theme optimized for monochrome". Idea happens some other textures could be colorized same way as tetris shape, so we could use gray textures instread of green or amber (needs to be consolidated, maybe next development iteration)

Rewrote the API.md theming area: https://github.com/bell07/minetest-laptop/blob/more_theming_support/API.md#themes

Still unhappy with nex prefixes (not in API.md). Note: Each prefix can have textures _background and _button, and colors _bgcolor, _textcolor.

Introducing get_bgcolor_box() I added bgcolors to "major" / "minor" / "contrast". Looked to "Save as" dialog.

    app_background -  the "default" app background (white) (prefix "app")

    alt_background -  Underlay under table - prefix "alt" - > should it be prefix table (table_background?)

    background - prefix-less is implemented as fallback. Which idea is in mail app for this texture? Maybe it should be "app" or an other prefix?

P prefer to reduce the count of used prefixes to avoid redundancies

[Grizzly-Adam]

I used background, contrast_background, and alt_background in mail. All image files. You already have app_background to make the title bar. Ideally I woukd like it if we could use codes for all the colors. A lot of our prefixes come from the need for both background and bgcolor.

On Tue, Mar 20, 2018 at 1:00 PM, bell07 notifications@github.com wrote:

Introduced theme.monochrome_textcolor is set in both monochrome themes and used in tetris app. This attribute means "theme optimized for monochrome". Idea happens some other textures could be colorized same way as tetris shape, so we could use gray textures instread of green or amber (needs to be consolidated, maybe next development iteration)

Rewrote the API.md theming area: https://github.com/bell07/minetest-laptop/blob/more_theming_support/API.md#themes

Still unhappy with nex prefixes (not in API.md). Note: Each prefix can have textures _background and _button, and colors _bgcolor, _textcolor.

Introducing get_bgcolor_box() I added bgcolors to "major" / "minor" / "contrast". Looked to "Save as" dialog.

app_background - the "default" app background (white) (prefix "app")

alt_background - Underlay under table - prefix "alt" - > should it be prefix table (table_background?)

background - prefix-less is implemented as fallback. Which idea is in mail app for this texture? Maybe it should be "app" or an other prefix?

P prefer to reduce the count of used prefixes to avoid redundancies

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/102#issuecomment-374697767, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCdbPtJg123IMqCjKwR5Apfp3xV-_ks5tgUPNgaJpZM4SSiUn .

[bell07]

I see the app_background is not usable because of title bar. can you propose which prefix have which meaning and which of them are maybe redundant and coul be removed? : major, minor, app, alt, table, muted

We need an explanation for all prefixes, the API should be understandeable for the case a new developer needs to write a fully new theme, the settings meaning should be predictable. Of course all elements was added on need, I try to consolidate them after is known what is needed :-)

"background" needs to be prefixed. I think the "fallback" values without prefix should be removed, (background, bgcolor, textcolor) because irritated.

[Grizzly-Adam]

Let me look at the code of mail app when I get home. Maybe major/minor can work for other things.

On Tue, Mar 20, 2018 at 3:27 PM, bell07 notifications@github.com wrote:

I see the app_background is not usable because of title bar. can you propose which prefix have which meaning and which of them are maybe redundant and coul be removed? : major, minor, app, alt, table, muted

We need an explanation for all prefixes, the API should be understandeable for the case a new developer needs to write a fully new theme, the settings meaning should be predictable. Of course all elements was added on need, I try to consolidate them after is known what is needed :-)

"background" needs to be prefixed. I think the "fallback" values without prefix should be removed, (background, bgcolor, textcolor) because irritated.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/102#issuecomment-374744805, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCYpGxg8QsZ2Sl1Tusy8ofQNsaHQqks5tgWYggaJpZM4SSiUn .

[bell07]

I did some more consolidation. See my branch / PR to your repo:

1. I disabled/removed fully the alt_background, did not seen any difference. Tested on greenshell (black vs. black) and on cubic (white vs. grey) and some other themes. I do not like the idea for second background over the app_background. If anything needed, the app_background needs to be adjusted, or other elements added.

2. in mail app now the "table_background" instread of "background". Thesetting it is related to the table set (should be always the same color as RGB bgcolor?)

3. Removed minor_bgcolor and major_bgcolor (was tech demo for get_bgcolor_box()). Use now the "contrast" and "table_highlight" prefixes in "Save as" dialog.

4. Updated the API again, reordered settings in default theme (themes.lua) to match the API order

5. The Ambershell and Greenshell does have the bright color for contrast. The contrast is for "white texts in edit fields" so it should be dark per definition. Can we change them to something more dark?

[Grizzly-Adam]

We don't use anything with the app prefix except app_background,. Maybe fold that into major? You did good figuring out how to remove the need for alt_background. I looked at all the others and it would cause a lot of compromised with our themes to remove any of them. The less options, the less we can emulator computers of various eras.

Re #5 Monochrome contrast. I have tried setting this as dark, but it looks awful because you just end up with a nearly black screen with text that has been tinted not quite the right color. Looks way better orange/green with dark text. It works well and I think we are better leaving it alone. If we change it, we would want to change the background color to orange/green to make the "contrast" color to stand out-- and that hurts the eyes because it becomes too much bright color.

I found a screen that did not get properly monochromed and was hoping you could take a look at it. In os_print_app.lua

[bell07]

We don't use anything with the app prefix except app_background,. Maybe fold that into major?

the meaning content does not match. But maybe the titlebar_textcolor should be "app_textcolor"? Or we should split the background to 2x images: the titlebar and the background? Maybe next iteration, I tink we should finalize the work.

I have tried setting this as dark, but it looks awful because you just end up with a nearly black screen with text that has been tinted not quite the right color. Looks way better orange/green with dark text.

The "contrast" prefix is for "dark background to place under white text elements that does not support textcolor". Of course it looks beter with dark text on orange/green, but not always possible. The contrast image was used on some other places too, therefore we added "contrast_textcolor" (some labels are placed on contrast background. This color is used to colorize them)

The Print app is a good example. Ok, the big text preview area I can theme now to "table" since it is not editable, but the "Heading" input field not, therefore the texture under them needs to be dark. The "Heading" label is "contrast_textcolor"

Other screens that needs attention for contrast images are the Text editor, New Mail view, Save as does have filename input fields

[bell07]

Applied the "table" theming to the preview in printer app. Changed the Heading underlay to get_bgcolor_box("","contrast"), and Heading text to "contrast_textcolor" that is amber now in amber theme.

The table_background under text areas looks strange on themes using "table_border". Maybe you can create new textures for with 1x Pixel border for such "table_background"?

[Grizzly-Adam]

Yeah, I can do that. I would like to have a border on the right payne of the mail app too.

On Wed, Mar 21, 2018 at 12:59 AM, bell07 notifications@github.com wrote:

Applied the "table" theming to the preview in printer app. Changed the Heading underlay to get_bgcolor_box("","contrast"), and Heading text to "contrast_textcolor" that is amber now in amber theme. [image: image] https://user-images.githubusercontent.com/4731334/37696193-305a3d06-2cd5-11e8-934d-9c97ed8a74d1.png

The table_background under text areas looks strange on themes using "table_border". Maybe you can create new textures for with 1x Pixel border for such "table_background"?

[image: image] https://user-images.githubusercontent.com/4731334/37696160-ef758d90-2cd4-11e8-85fd-87bbdce14802.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/102#issuecomment-374840563, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCfYAbxXFMQA_upWJhrdRIf61heb7ks5tgexNgaJpZM4SSiUn .

[bell07]

The mail app uses the same logic for text area is themed using table prefix ("table_background"). So it should work out of the box for mail, if it does work for print file. I fear the border line scaling issues because of different area sizes :-(

[Grizzly-Adam]

I have several 1x1 images in the textures fokder, grab one of them and see uf it works. I plan to rename all the 1x1s so they have aimilar names and are more available to all themes-- also will be easier to purge them all should we no longer need them.

On Wed, Mar 21, 2018 at 8:08 AM, bell07 notifications@github.com wrote:

The mail app uses the same logic for text area is themed using table prefix ("table_background"). So it should work out of the box for mail, if it does work for print file. I fear the border line scaling issues because of different area sizes :-(

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/102#issuecomment-374930298, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCUrcqxSsOXkWCwsal0rnentqVFrNks5tglDSgaJpZM4SSiUn .

[bell07]

$ file textures/* | grep '1 x 1'
textures/laptop_theme_ambershell_desktop_icon_label_button.png: PNG image data, 1 x 1, 8-bit/color RGB, non-interlaced
textures/laptop_theme_boing_major_button.png:                   PNG image data, 1 x 1, 8-bit/color RGB, non-interlaced
textures/laptop_theme_clouds_desktop_icon_label_button.png:     PNG image data, 1 x 1, 1-bit colormap, non-interlaced
textures/laptop_theme_colors_light_grey.png:                    PNG image data, 1 x 1, 8-bit/color RGB, non-interlaced
textures/laptop_theme_desktop_icon_label_button_black.png:      PNG image data, 1 x 1, 1-bit colormap, non-interlaced
textures/laptop_theme_desktop_icon_label_button_darkblue.png:   PNG image data, 1 x 1, 8-bit/color RGB, non-interlaced
textures/laptop_theme_desktop_icon_label_button_grey.png:       PNG image data, 1 x 1, 1-bit colormap, non-interlaced
textures/laptop_theme_desktop_icon_label_button_white.png:      PNG image data, 1 x 1, 1-bit colormap, non-interlaced
textures/laptop_theme_greenshell_desktop_icon_label_button.png: PNG image data, 1 x 1, 8-bit/color RGB, non-interlaced
textures/laptop_theme_shell_desktop_icon_label_button.png:      PNG image data, 1 x 1, 8-bit/color RGB, non-interlaced

What do you mean I should test if works? All of them are used as "buttons" textures.

I checked all of them, the next are not used:

• laptop_theme_colors_light_grey.png
• laptop_theme_desktop_icon_label_button_darkblue.png

used only for table_color => can be converted to bigger texture with border

• laptop_theme_desktop_icon_label_button_white.png

Did you tried the borders for "table_background" images?

[Grizzly-Adam]

I read your post wrong, I thought you were going to use a 1x1 pixel image to make the border. I assumed you would do a top, bottom, left, and right images as the lines for the border. Now I understand that is not what you meant.

On Wed, Mar 21, 2018 at 4:32 PM, bell07 notifications@github.com wrote:

$ file textures/* | grep '1 x 1' textures/laptop_theme_ambershell_desktop_icon_label_button.png: PNG image data, 1 x 1, 8-bit/color RGB, non-interlaced textures/laptop_theme_boing_major_button.png: PNG image data, 1 x 1, 8-bit/color RGB, non-interlaced textures/laptop_theme_clouds_desktop_icon_label_button.png: PNG image data, 1 x 1, 1-bit colormap, non-interlaced textures/laptop_theme_colors_light_grey.png: PNG image data, 1 x 1, 8-bit/color RGB, non-interlaced textures/laptop_theme_desktop_icon_label_button_black.png: PNG image data, 1 x 1, 1-bit colormap, non-interlaced textures/laptop_theme_desktop_icon_label_button_darkblue.png: PNG image data, 1 x 1, 8-bit/color RGB, non-interlaced textures/laptop_theme_desktop_icon_label_button_grey.png: PNG image data, 1 x 1, 1-bit colormap, non-interlaced textures/laptop_theme_desktop_icon_label_button_white.png: PNG image data, 1 x 1, 1-bit colormap, non-interlaced textures/laptop_theme_greenshell_desktop_icon_label_button.png: PNG image data, 1 x 1, 8-bit/color RGB, non-interlaced textures/laptop_theme_shell_desktop_icon_label_button.png: PNG image data, 1 x 1, 8-bit/color RGB, non-interlaced

What do you mean I should test if works? All of them are used as "buttons" textures.

I checked all of them, the next are not used:

• laptop_theme_colors_light_grey.png
• laptop_theme_desktop_icon_label_button_darkblue.png

used only for table_color => can be converted to bigger texture with border

• laptop_theme_desktop_icon_label_button_white.png

Did you tried the borders for "table_background" images?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/102#issuecomment-375103036, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCbkOHVn3y0TOlHB5_uqSJzxgLDTqks5tgsbugaJpZM4SSiUn .

[bell07]

Found a beter way to solve the border problem: A empty themed table instead of background images. Implemented, see my branch / the PR in your repo.

Removed again the "table_backgrounds" setting and not used textures

• laptop_theme_colors_light_grey.png,
• laptop_theme_desktop_icon_label_button_darkblue.png,
• laptop_theme_desktop_icon_label_button_white.png

From my point of view all work is done now! Please review and test the changes if you see something is still missed. If not, we can setup the PR to upstream/master

EDIT: ok, forgot last thing: The "contrast" background should be still dark in ember and green theme. Maybe dark-amber and dark-green instread of black? Maybe with border on texture to avoid "full black screen"?

[Grizzly-Adam]

If I get the chance I will check PR tonight, test and issue pr to maon build tonight. But I wobt be home until late so it may have to wait until tomorrow.

On Thu, Mar 22, 2018 at 2:11 AM, bell07 notifications@github.com wrote:

Found a beter way to solve the border problem: A empty themed table instead of background images. Implemented, see my branch / the PR in your repo.

Removed again the "table_backgrounds" setting and not used textures

• laptop_theme_colors_light_grey.png,
• laptop_theme_desktop_icon_label_button_darkblue.png,
• laptop_theme_desktop_icon_label_button_white.png

From my point of view all work is done now! Please review and test the changes if you see something is still missed. If not, we can setup the PR to upstream/master

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/102#issuecomment-375200787, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCfnPXTzAo4vT7WCAGvWQmQWffdgJks5tg06_gaJpZM4SSiUn .

[bell07]

Ok, I changed back the "contrast" to amber/green in the both themes. Previously some parts (Write mail screen for example) was colorized using contrast_bgcolor/contrast_textcolor as I expected, but looks not nice. No rule without exception, the both monochrome themes uses bright background for not themeable white text. Looks beter but more exhausting to read. Like the old monitors ;-)

If you merges my both commits to your branch we can merge them

[bell07]

All Changes merged!