Gerold55 / laptop

Introducing the MineTest Laptop Mod
Other
25 stars 14 forks source link

Mail has to be opened twice #112

Closed Grizzly-Adam closed 6 years ago

Grizzly-Adam commented 6 years ago

Click mail. It doesn't open. Click it again, it opens.

In CS-BOS type mail-- it says mail launched. Type mail again. It opens.

bell07 commented 6 years ago

I tested it with your master and your master and your more_theming_support branches and cannot get the error.

Maybe broken data in hardware? Can you test again with new fresh computer? May we need "factory reset" or "FORMAT HDD:" for such reason.

Grizzly-Adam commented 6 years ago

I hqve had this ongoing but kept forgetting to report it I have done numerous installs but can try a new one again tonight.

On Tue, Mar 13, 2018 at 12:56 AM, bell07 notifications@github.com wrote:

I tested it with your master and your master and your more_theming_support branches and cannot get the error.

Maybe broken data in hardware? Can you test again with new fresh computer? May we need "factory reset" or "FORMAT HDD:" for such reason.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/112#issuecomment-372555399, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCdnE5b6UXqBYdi0a5Fjj8xcKtymjks5td199gaJpZM4Sn5fR .

bell07 commented 6 years ago

I get the issue once in a new world with a new laptop .. try to repeat them

Grizzly-Adam commented 6 years ago

Fresh install, new world, new computers. Have to click/type mail twice to run it. Opens fine the second time. Shut off the computer, and its back to having to run it twice.

bell07 commented 6 years ago

Yes, found if. Fresh booted computer have the issue too. The "last player" info is missed at first try so the app closes automatically for security reason, because the player unknown)

Grizzly-Adam commented 6 years ago

Sweet!

bell07 commented 6 years ago

I did some changes on mail app to solve it (last_player is now current_player in most cases). I know you did some changes on this app too for theming. Can you upload your version so I can merge them together?

Grizzly-Adam commented 6 years ago

My latest version is in my git, in the more_theming _support branch.

https://github.com/Grizzly-Adam/minetest-laptop/tree/more_theming_support

bell07 commented 6 years ago

Ok, created pull request to the upstream master and to your more_theming_support branch

113 and https://github.com/Grizzly-Adam/minetest-laptop/pull/1

Grizzly-Adam commented 6 years ago

The version you merged to my git fails to launch.

bell07 commented 6 years ago

Which error? I tested it before creating the PR

Grizzly-Adam commented 6 years ago

Maybe you changed things in other files, I thought it was only the mail app you changed so I only installed it. In csbos it says launched, in launcher it does nothing.

On Tue, Mar 13, 2018 at 6:10 PM, bell07 notifications@github.com wrote:

Which error? I tested it before creating the PR

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/112#issuecomment-372849552, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCRKHn388kOoypjxyC_SrQYg9pGxlks5teFHHgaJpZM4Sn5fR .

bell07 commented 6 years ago

You should not think in files but in changes ;) Of course I changed more files. The important change is in mtos.lua

Grizzly-Adam commented 6 years ago

Thanks. I will give it a quick go.

On Tue, Mar 13, 2018 at 6:14 PM, bell07 notifications@github.com wrote:

You should not think in files but in changes ;) Of course I changed more files. The important change is in mtos.lua

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/112#issuecomment-372850626, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCdzk2y9qdJQ-KTW7-YoHiwPY8oQhks5teFLvgaJpZM4Sn5fR .

Grizzly-Adam commented 6 years ago

Works great on this end.