Gerold55 / laptop

Introducing the MineTest Laptop Mod
Other
26 stars 14 forks source link

main page ignores browser_main_page value. #131

Open morlanius opened 6 years ago

morlanius commented 6 years ago

https://github.com/Gerold55/minetest-laptop/blob/f3dae69bc31c3edf3cc4859a22dfe62674752f0b/apps/browser_app.lua#L71

to if def.browser_page and mtos:is_app_compatible(name) and def.browser_main_page.then

bell07 commented 6 years ago

Just set the "browser_page" for the main page instead of browser_main_page.

Where did you get the browser_main_page from? It is not defined in API.md

morlanius commented 6 years ago

browser_page doesn't seem to be effecting if it is shown on the main page or not and not setting it makes the page unavailable. I saw in one of the templates you have browser_main_page set, so I used that and added a check for it in the main page. Now the main page shows me my pages, and the wiki main page but not its sub pages.