Gerold55 / laptop

Introducing the MineTest Laptop Mod
Other
26 stars 14 forks source link

app-request: Arcade tetris emulator #41

Closed bell07 closed 6 years ago

bell07 commented 6 years ago

Port https://github.com/minetest-mods/homedecor_modpack/blob/master/computer/tetris.lua to own app called "Tetris Arcade emulator" ...

Gerold55 commented 6 years ago

Couldn't the Tetris pieces be made up out of wool?

bell07 commented 6 years ago

Sure, and good point. I do not like to copy textures from homedecor mod to laptop mod. So we need own textures. Or we just use the wool textures.

Gerold55 commented 6 years ago

Or just a single white texture and colorize it in the code or something like that. But we can test different textures out and see which one fits together.

bell07 commented 6 years ago

First draft in my master and in your development branch ...

Gerold55 commented 6 years ago

Should we try to use colored blocks instead of wool? Or make the wool a bit tighter together?

bell07 commented 6 years ago

It's possible to use 1 white texture and colorize them using color codes. I like the idea to remove the wool and use colorized texture

Gerold55 commented 6 years ago

I believe that one of the textures used is only white.

bell07 commented 6 years ago

Can you work on texture replacement? Or provide the white texture name and #RGB values for coloring?

Gerold55 commented 6 years ago

Laptop_fruit_base.png

bell07 commented 6 years ago

I used the diamond-block from default mod because it looks better. The visual is ok for me for now. If you like to do some additional adjustments, just edit and play around the next values in file tetris_app.lua

local base_color_texture = "default_diamond_block.png"
local base_color_alpha = '128'
local sizex, sizey, size = 0.42, 0.44, 0.47

The board background is defined at bottom in return 'container[3,1]background[0,-0.05;4.35,9;'.. mtos.theme.contrast_bg.... Just edit the 4.35 (width) and 9 (high).

bell07 commented 6 years ago

The game launcher icon is missed also. Can you create one? If the launcher icon is done and the current app state is ok for you, I can prepare the pull request. This time merging development is not the best way because some printer files already in development that should not be to master at the time.

Gerold55 commented 6 years ago

Ok I'll take a look at it soon.

Gerold55 commented 6 years ago

Looks ok to me and the community. @kingoscargames is working on an icon for it.

bell07 commented 6 years ago

Ok, if I am afk and the icon is done, I prepared the branch "pr_tetris" https://github.com/Gerold55/minetest-laptop/compare/master...bell07:pr_tetris you can merge and adjust to use the new icon. Of course you can adjust the labels. Unsure if the "Arcade tetris emulator" is still a good name

bell07 commented 6 years ago

merged