Gerold55 / laptop

Introducing the MineTest Laptop Mod
Other
26 stars 14 forks source link

Recipes #73

Open bell07 opened 6 years ago

bell07 commented 6 years ago

At the time the laptop:monitor4, laptop:monitor3 and laptop:laptop does have an recipe. All laptops/computers should be crafteable. In addition the items floppy and usb needs an crafting recipe too

Gerold55 commented 6 years ago

Could it also be possible to make something where you can just but the laptops and printer? Because there's only so many recipes that can be done for the laptops.

bell07 commented 6 years ago

I did not understand, my bad english :-( Do you mean a way to add automatically recipes by hardware registration in according any template?

Gerold55 commented 6 years ago

To add a node/item where you'll be able to buy the laptops/computer and printer

bell07 commented 6 years ago

The printer recipe can to the development brach till printer is ready for master. Other recipes could go directly to master after short text

bell07 commented 6 years ago

Ah, something "workbench"- like? I like the classic recipes. A recipe could be expensive too with gold and diamonds

Gerold55 commented 6 years ago

Yeah ik but to create something where you trade some kind of ore of a few materials to get a certain laptop so we could add as many computers without conflicting recipes :)

bell07 commented 6 years ago

Maybe one own craftitem like "laptop chip" that is used once in all recipes? This way no overlaps to other mods happens. Of course we need a recipe for the chip too

Gerold55 commented 6 years ago

So like copper melted down in a furnace into a computer chip? Or something like that?

bell07 commented 6 years ago

I like something like homedecor:ic Maybe use them if homedecor installed

bell07 commented 6 years ago

If no homedecor installed, copper smelting is fine, but we need sand for silicium in recipe

Gerold55 commented 6 years ago

laptop_copper_chip

laptop_silicon

Gerold55 commented 6 years ago

How do those look @bell07

bell07 commented 6 years ago

What is it?

Gerold55 commented 6 years ago

It's supposed to be silicon and copper chip but darianbrown had an idea to do the recipes. glass -> tempered glass. Gold copper and iron for the chips and some other ore components to make the individual computers.

bell07 commented 6 years ago

Sounds good!

bell07 commented 6 years ago

Any news?

Gerold55 commented 6 years ago

So we are gonna be using mesecons with the laptop mod to be able to properly create crafting recipes.

Gerold55 commented 6 years ago

Is there a way to change/override the recipes for mesecons? @Grizzly-Adam @Bell07

Grizzly-Adam commented 6 years ago

I have never messed with the messecons mod, but we should be able to override a recipe fairly easily. Of course we will them become at least soft-dependent on messecons.

Grizzly-Adam commented 6 years ago

Please provide link to mesecons mod.

Grizzly-Adam commented 6 years ago

https://github.com/minetest-mods/mesecons

If this is the mod, they are just using minetest.register_craft which we can override as we wish.

Should be able to do something like this:

if  minetest.registered_items["mesecons_lamp:lamp_off"] ~= nil then
minetest.override_item("mesecons_lamp:lamp_off", {
    recipe = {
        {"", "default:glass", ""},
        {"group:mesecon_conductor_craftable", "default:steel_ingot", "group:mesecon_conductor_craftable"},
        {"", "default:glass", ""},
})
end
bell07 commented 6 years ago

What are you going to do? Ususally nothing should be overriden that is registered by other mods. But I think it is not needed. CAn you pls. provide your mesecons-related idea?

Gerold55 commented 6 years ago

To redo recipe for something like the lightstones so it would make more sense to use them for the screen.

bell07 commented 6 years ago

Usually a player that know mesecons (a well-known mod for minetest) does not expect the recipes are changed after the laptop mod is installed. Please note the mesecons is used for other reasons then laptop too. Please don't. If mesecons items does not fully match our requirements, we need own items, maybe crafteable from pr convertable to the mesecons items

Grizzly-Adam commented 6 years ago

On Sat, Mar 3, 2018 at 8:10 AM, bell07 notifications@github.com wrote:

Usually a player that know mesecons (a well-known mod for minetest) does not expect the recipes are changed after the laptop mod is installed. Please note the mesecons is used for other reasons then laptop too. Please don't. If mesecons items does not fully match our requirements, we need own items, maybe crafteable from pr convertable to the mesecons items

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/73#issuecomment-370150067, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCcCxuaK-Sy6ht3_HyFmkwwf9L6V4ks5taqRKgaJpZM4RUdic .

Exactly, we can make our own recipe that outputs the mesecon item while leaving the original recipe alone.

Gerold55 commented 6 years ago

Yeah 2 different recipes for the item.

Gerold55 commented 6 years ago

@bell07 @Grizzly-Adam how do I add items to the mod? I want to add the components to the mod so I can get the in-game images so it'll be easier for me to layout the recipes before I code in the recipes.

bell07 commented 6 years ago

Look to the items.lua for already existing items ;-)

At minimum there should be

minetest.register_craftitem("laptop:newitem", {
    description = 'NEw ITem',
    inventory_image = "laptop_item.png",
})

If you need additional settings see: http://dev.minetest.net/minetest.register_craftitem and for recipes see: http://dev.minetest.net/minetest.register_craft

Gerold55 commented 6 years ago

screenshot 158

Gerold55 commented 6 years ago

lcd_recipe

bell07 commented 6 years ago

Looks very nice! :+1:

Gerold55 commented 6 years ago

The components recipes are almost finished.

Gerold55 commented 6 years ago

@bell07 @Grizzly-Adam I've added the recipes for the components. I haven't done the recipes for the computers yet so if y'all are interested in helping with that you can

bell07 commented 6 years ago

Thanks! Really nice!

I looked trough the recipes and (as usual ;-)) have some remarks:

About mesecons: We do not support the "core functionality" of mesecons at the time, so using the mesecons items in recipes feels wrong. Mesecons is "power supply" with some on/off logic (like known redstone in other blocks game). Our laptops does not deal without power, and I do not like the idea to power laptop on/off by wall_lever

Gerold55 commented 6 years ago

Would you be able to make the edits? I'm about to head to bed. I can send the component files to you also. Github was having trouble with uploading the textures. It was picking and choosing the files it wants to upload.

bell07 commented 6 years ago

I did some file renames and moved items.lua to craftitems.lua. Recipes still missed because of missed ideas on my site :-( The texture still missed too

Gerold55 commented 6 years ago

Components.zip

Gerold55 commented 6 years ago

@bell07 I've just added the textures for the components for you.

bell07 commented 6 years ago

Uploaded missing laptop_case.png Seen we have now "laptop_hard_drive.png" (Removable app icon) and "laptop_harddrive.png" (Item). Therefore renamed laptop_hard_drive.png to laptop_removable.png

Seen the current concept for hardware recipes. Try to do it in evening. If not, the next days I am AFK.

In concept the Floppy and USB-Stick are missed. Ideas for crafting recipes?

bell07 commented 6 years ago

@Gerold55 can you please update the credits for new items in README.md? You can direct use the Edit README.md on github. If you not firm with the MD-syntax just look how the existing items are listed and use "preview changes" before commit

Gerold55 commented 6 years ago

I'll add it as soon as possible. I was working today and I have the evening off. Will get a proof of concept done and uploaded.

Gerold55 commented 6 years ago

I've added the USB and Floppy recipe concepts.

bell07 commented 6 years ago

You ignored my last chages and did overridden them. Therefore there is no usb and floppy definition anymore in the file. Again, please install any client and learn how to use git. I am on the road and cannot do anything till weekend. Please do not push directly to master incomplete work. The git branches exists to collect changes/commits till the work is completed. Each enhancement should have own branch, so the right way is: create new branch with change-related name (like "crafting_recipes"), push all work on recipes to this branch. If all work is done, create pull request, review, merge, delete branch..

Grizzly-Adam commented 6 years ago

What file do you have them in, i downloaded a version before his latest update I think.

On Tue, Mar 6, 2018 at 9:24 PM, bell07 notifications@github.com wrote:

You ignored my last chages and did overridden them. Therefore there is no usb and floppy definition anymore in the file. Again, please install any client and learn how to use git. I am on the road and cannot do anything till weekend. Please do not push directly to master incomplete work. The git branches exists to collect changes/commits till the work is completed. Each enhancement should have own branch, so the right way is: create new branch with change-related name (like "crafting_recipes"), push all work on recipes to this branch. If all work is done, create pull request, review, merge, delete branch..

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/73#issuecomment-371010078, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCcEyfA1ZBCbAo4mC3Q8Lrirjl7Izks5tb1LggaJpZM4RUdic .

Gerold55 commented 6 years ago

Oh ok sorry bout that. Could you repush your edits? On Mar 6, 2018 10:24 PM, "bell07" notifications@github.com wrote:

You ignored my last chages and did overridden them. Therefore there is no usb and floppy definition anymore in the file. Again, please install any client and learn how to use git. I am on the road and cannot do anything till weekend. Please do not push directly to master incomplete work. The git branches exists to collect changes/commits till the work is completed. Each enhancement should have own branch, so the right way is: create new branch with change-related name (like "crafting_recipes"), push all work on recipes to this branch. If all work is done, create pull request, review, merge, delete branch..

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/73#issuecomment-371010078, or mute the thread https://github.com/notifications/unsubscribe-auth/ANM6l17sSXr88BBzP1vNEsmiRtmiUio9ks5tb1LggaJpZM4RUdic .

bell07 commented 6 years ago

I converted craftitems.lua dos2unix and moved the usb-, floppy- and paper definition to this file. Then I removed the items.lua

Grizzly-Adam commented 6 years ago

@Gerold55 I have forked the main build and uploaded bell's craftitems.lua to it. Please check the compare and merged the appropriate changes. https://github.com/Gerold55/minetest-laptop/compare/master...Grizzly-Adam:master

Gerold55 commented 6 years ago

We need to get these recipes done. The laptop mod was just added on a server.

Grizzly-Adam commented 6 years ago

I will work on the ones for the addon packs.

On Thu, Mar 8, 2018 at 6:54 PM, Gerold55 notifications@github.com wrote:

We need to get these recipes done. The laptop mod was just added on a server.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/73#issuecomment-371676822, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCXg1flUxUYS7MpgI3xSvgc_R2zsYks5tcdKygaJpZM4RUdic .

Gerold55 commented 6 years ago

Ok I think I'm gonna work on the ones for the laptop mod. Bell wanted to change the recipes. I think they are fine though.

On Mar 8, 2018 8:12 PM, "Grizzly Adam" notifications@github.com wrote:

I will work on the ones for the addon packs.

On Thu, Mar 8, 2018 at 6:54 PM, Gerold55 notifications@github.com wrote:

We need to get these recipes done. The laptop mod was just added on a server.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/73# issuecomment-371676822, or mute the thread https://github.com/notifications/unsubscribe-auth/ AhktCXg1flUxUYS7MpgI3xSvgc_R2zsYks5tcdKygaJpZM4RUdic .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/issues/73#issuecomment-371680036, or mute the thread https://github.com/notifications/unsubscribe-auth/ANM6l7weer5FbQsgu8ZRAJTewgiWIvo1ks5tcdcEgaJpZM4RUdic .