Updates for theme - Githubissues

Grizzly-Adam commented 6 years ago

Added three more options for themes: taskbar_clock_position_and_size, exit_character, and titlebar_textcolor. Added four themes based on various operating systems.

bell07 commented 6 years ago

I tested the new skins, F*cking nostalgia, I did not seen Win-98 since ~15 years. Really Great Work! Please adjust the label position if no "Back" button there as mentionend in review, and please add the new theming parameter to the API.md, then the merge is approved from my site

Grizzly-Adam commented 6 years ago

I will. Working on it during breqks at work.

On Fri, Feb 16, 2018 at 7:58 AM, bell07 notifications@github.com wrote:

@bell07 commented on this pull request.

In API.md https://github.com/Gerold55/minetest-laptop/pull/87#discussion_r168762151 :

@@ -113,6 +113,10 @@ Definitiontable:

major_button Major (highlighted) button image

minor_button Minor button image

node_color Palette number to set if the node is paramtype2 = "colorfacedir" +- taskbar_clock_position

taskbar_clock_position_and_size

Pls. add short description what the setting does

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Gerold55/minetest-laptop/pull/87#pullrequestreview-97184787, or mute the thread https://github.com/notifications/unsubscribe-auth/AhktCUOMHJ_RlAnyKwz5OzDo_HRyS7U6ks5tVYltgaJpZM4SHsFW .

Grizzly-Adam commented 6 years ago

Ok, it is ready.

bell07 commented 6 years ago

The attribute is "taskbar_clock_position_and_size", not "taskbar_clock_position"

Grizzly-Adam commented 6 years ago

Copy and paste fail. It should be good to go now.

Grizzly-Adam commented 6 years ago

Anything else I need to do or will all this fall into place now?

Gerold55 / laptop

Updates for theme #87

@bell07 commented on this pull request.