search

Gerold55 / laptop

Introducing the MineTest Laptop Mod
Other
26 stars 14 forks source link

realchess app added #96

Closed bell07 closed 6 years ago

bell07 commented 6 years ago

As requested in #62

bell07 commented 6 years ago

@Gerold55 @Grizzly-Adam please for testing and review. Can this app be merged as is?

Grizzly-Adam commented 6 years ago

It looked good to me. I say merge.

bell07 commented 6 years ago

I am unsure about gameplay. I tried it in singleplayer only: Me vs. Me, and missed the "undo" button sometimes ;-(

Grizzly-Adam commented 6 years ago

I will try to get the old lady to play with me in a short while and see how it works. If she is feeling up to it.

Gerold55 commented 6 years ago

Is this ready to be merged or no?

Grizzly-Adam commented 6 years ago

Hold on, I will give it a quick 2 player test. It fell off my radar when she wasn't well enough to test with me the day after her surgery.

Gerold55 commented 6 years ago

Oh sorry to hear that 😞^

Grizzly-Adam commented 6 years ago

She had cancer removed from her forehead on Tuesday, which is why I had time off and was on here so much this week.

@Gerold55 please see my update to PC Pack, it's just two lines but it will need to be merged when we release CS-BOS.

Grizzly-Adam commented 6 years ago

We very quickly ended up being able to move the pieces where ever we wanted, with no regard to the rules of the game.

Gerold55 commented 6 years ago

@bell07

bell07 commented 6 years ago

Grizzly-Adam commented 20 hours ago We very quickly ended up being able to move the pieces where ever we wanted, with no regard to the rules of the game.

That is what I meant :-(

@Grizzly-Adam ,did you tried the "original" already I copied the game from? https://github.com/minetest-mods/realchess Unsure if it is my fault or I copied the bug from template. My initial idea was "just quickly reuse the code with some laptop-related adjustments". If the reused code is buggy anyone needs to take over the development, I am not a chess-player :-/

Grizzly-Adam commented 6 years ago

@bell07 I used the version included in xdecor. Chances are the bug carried over from the original version, but I couldn't recreate in on that board. It maybe have just been an odd set of events that caused it.

bell07 commented 6 years ago

Compared the code from xdecor and realchess. Both is the same, so I am searching for my own bug now

bell07 commented 6 years ago

Ok, found the bug, need to cut the "laptop:" from pieces names. @Grizzly-Adam, please try again if the game is playable now.

Grizzly-Adam commented 6 years ago

OK, give me a few. I will need to push an update to my server and the kids are playing on it.

Grizzly-Adam commented 6 years ago

On first move of the game, pawn can be moved anywhere in second row up. This is only for the first player.

bell07 commented 6 years ago

Same behaviour in xdecor version?

Grizzly-Adam commented 6 years ago

Oh yep!!! It's not your bug!

bell07 commented 6 years ago

Then you can open issue for xdecor and/or for minetest-mods/realchess projects. Maybe an other developer can solve it. Or if you like, you can try to fix it, I think you know enough lua in meantime to do it ;-)

bell07 commented 6 years ago

What's about this PR? Can we merge them despite the pawn bug in first step?

Grizzly-Adam commented 6 years ago

Yes, its not our bug.