search

GerritErpenstein / ionic2-custom-icons

A npm-script for creating custom icon fonts and Angular 4 directives to render the icons in your Ionic 3 app.
MIT License
62 stars 15 forks source link

Can I use this for Ionic 4? #36

Open ThorvaldAagaard opened 6 years ago

ThorvaldAagaard commented 6 years ago

I am currently migrating my app to Ionic 4, and would like to know if this module works, or I have to change anything.

ThorvaldAagaard commented 6 years ago

Answering my own question :-)

Currently not

I get the following errors:

[ng] chunk {explore-explore-module~tabs-tabs-module} explore-explore-module~tabs-tabs-module.js, explore-explore-module~tabs-tabs-module.js.map (explore-explore-module~tabs-tabs-module) 127 kB  [rendered]
[ng] ERROR in ./node_modules/ionic2-custom-icons/ionic/dist/action-sheet/action-sheet-custom-icon-controller.js
[ng] Module not found: Error: Can't resolve 'ionic-angular' in 'D:\Documents\github\geme.io\node_modules\ionic2-custom-icons\ionic\dist\action-sheet'
[ng] ERROR in ./node_modules/ionic2-custom-icons/ionic/dist/icon/custom-icon.directive.js
[ng] Module not found: Error: Can't resolve 'ionic-angular' in 'D:\Documents\github\geme.io\node_modules\ionic2-custom-icons\ionic\dist\icon'
[ng] ERROR in ./node_modules/ionic2-custom-icons/ionic/dist/tabs/tab-custom-icon.directive.js
[ng] Module not found: Error: Can't resolve 'ionic-angular' in 'D:\Documents\github\geme.io\node_modules\ionic2-custom-icons\ionic\dist\tabs'
[ng] ERROR in ./node_modules/ionic2-custom-icons/ionic/dist/tabs/tab-custom-icon.directive.js
[ng] Module not found: Error: Can't resolve 'rxjs/observable/fromPromise' in 'D:\Documents\github\geme.io\node_modules\ionic2-custom-icons\ionic\dist\tabs'
[ng] i ｢wdm｣: Failed to compile.
[ng] ERROR in node_modules/ionic2-custom-icons/ionic/dist/action-sheet/action-sheet-custom-icon-controller.d.ts(1,42): error TS2307: Cannot find module 'ionic-angular'.
[ng] node_modules/ionic2-custom-icons/ionic/dist/action-sheet/action-sheet-custom-icon-options.d.ts(1,36): error TS2307: Cannot find module 'ionic-angular'.
[ng] node_modules/ionic2-custom-icons/ionic/dist/custom-icon-base.d.ts(1,24): error TS2307: Cannot find module 'ionic-angular'.
[ng] node_modules/ionic2-custom-icons/ionic/dist/icon/custom-icon.directive.d.ts(2,24): error TS2307: Cannot find module 'ionic-angular'.
[ng] node_modules/ionic2-custom-icons/ionic/dist/tabs/tab-custom-icon.directive.d.ts(2,35): error TS2307: Cannot find module 'ionic-angular'.
GerritErpenstein commented 6 years ago

Hi @ThorvaldAagaard, this is definitely on my todo list. I will look into it in the next few days.

mrayoub commented 5 years ago

Hi @GerritErpenstein, some news about this update?

amayvs commented 5 years ago

Hi @GerritErpenstein, did you get a chance to look into this?

marcogrieco commented 5 years ago

Hi, the example app doesn't work with this configuration

Ionic: ionic (Ionic CLI) : 4.12.0 (/usr/local/lib/node_modules/ionic) Ionic Framework : ionic-angular 3.9.2 @ionic/app-scripts : 3.1.10

because there is a Sass Error

File to import not found or unreadable: .tmp-custom-icons/scss/variables.scss.

Thanks in advance

Marco