search

Gert-dev / php-ide-serenata

Atom IDE package that integrates the Serenata server to provide PHP code assistance
https://serenata.gitlab.io/
Other
274 stars 19 forks source link

Rename php_integrator project key #426

Closed Gert-dev closed 6 years ago

Gert-dev commented 6 years ago

The project name has changed and this key should be updated also.

We should provide a transition path for existing projects.

twifty commented 6 years ago

The blitz module I mentioned earlier is now ready. It should allow you to easily transition the settings.

atom-blitz-settings

Gert-dev commented 6 years ago

Thanks for the heads up. I'm not sure if I can use it, though, seeing as this specifically entails project settings in projects.cson and not the package's settings itself. I'll keep an eye on it if I ever do need that, though!

twifty commented 6 years ago

@Gert-dev Not sure what you mean by "not the package's settings itself". The package settings are stored within config.cson which this package fixes. It doesn't touch the 'project.cson, which is usually in the project root, and not sure whatprojects.cson` you are referring to.

Gert-dev commented 6 years ago

@twifty I meant that the php_integrator key is stored in projects.cson, not in config.cson, which can not be migrated using atom-blitz-settings, I think.

twifty commented 6 years ago

Ahh, that makes sense. blitz depends on a package's configSchema to identify erroneous keys. Applying a similar method to projects.cson would be problematic since 1) there is no schema involved, and 2) the root keys are arbitrary.

This again highlights the need for atom to implement a per project configuration. Their current implementation is targeted at only dev teams and not suitable for what we need. Perhaps they should have named the file team.cson rather than project.cson (not to be confused with projects.cson in the .atom dir).