Properly transition to ES6 JavaScript from CoffeeScript

Gert-dev / php-ide-serenata

Atom IDE package that integrates the Serenata server to provide PHP code assistance

https://serenata.gitlab.io/

Other

273 stars 19 forks source link

Properly transition to ES6 JavaScript from CoffeeScript #433

Open Gert-dev opened 6 years ago

Gert-dev commented 6 years ago

Using the decaffeinate project the initial code has been converted to JavaScript (see #375 or 293eb2020bfe781e96235167c74b20ed6dc41295). This is just the first step however, as there are other things to do:

[ ] Implement suggestions shown on top of each file
[x] Set up ESLint
- [x] Fix "atom" not being recognized by ESLint
- [ ] Investigate enabling additional rules
- [x] Fix open issues shown by ESLint
[ ] Rewrite to use ES6 modules instead of require syntax

twifty commented 6 years ago

My fix for "atom" not being recognized is a /* global atom */ at the top of the file. I also tend to also specify global itself as a global /* global global atom */, that way I can do thing like global.setTimeout without ESLint complaining. Other items like console.log I do on a per-line basis so as not to leave forgotten debug/dev helpers in the code.