Gert-dev / php-ide-serenata

Atom IDE package that integrates the Serenata server to provide PHP code assistance
https://serenata.gitlab.io/
Other
275 stars 19 forks source link

Cannot read property 'dispose' of null at LinterProvider.deactivate #435

Closed Ulll closed 6 years ago

Ulll commented 6 years ago

screenshot

and these tasks take up much more cpu and memory ~

after I restart atom, they're still exist

the only thing I can do right now is add a shell script on osx launchctl , which would force kill unwanted processes

ps aux | grep Main.php  | sort -r | sed '1,2d' | awk '{print $2}' | xargs kill -9
Gert-dev commented 6 years ago

This should be working, at least on Linux (it does here). What I mean to say is: this was fixed before. Shutting down the server happens on package deactivation, but if something - such as another package - is causing an error on Atom shutdown, it may be the case that package deactivation never properly finishes. Have you tried disabling other community packages (if you have any)?

Ulll commented 6 years ago

@Gert-dev , I think it caused by https://github.com/atom/atom/issues/17020

chuhta commented 6 years ago

I also have this issue, but I'm using Ubuntu 16.04 with Atom 1.26 and 1.27.

I took a snapshot of the developer tools while shutting down.

Error from PHP IDE Serenata while shutting down Atom

Looking at the code in the LinterProvider, it might have to do with having the linter disabled. I use other more customized linters instead of the one provided by this package, so activate would possibly never be called.

Gert-dev commented 6 years ago

Alright, I'm renaming this since there does appear to be an issue in the LinterProvider at deactivation time.