search

Gert-dev / php-ide-serenata

Atom IDE package that integrates the Serenata server to provide PHP code assistance
https://serenata.gitlab.io/
Other
275 stars 19 forks source link

Separate exclusion list for linting and indexing #448

Closed ghost closed 4 years ago

ghost commented 6 years ago

Is there a way to separate the indexing folders for errors and code navigation ? I don't ant to search errors in vendors, but I want to navigate in it ...

Any idea ?

Gert-dev commented 5 years ago

Hello.

Could you indicate what you mean by searching errors? Do you mean that linting is also showing you problems with code in the vendor folder in the diagnostics panel?

ghost commented 5 years ago

Yes I mean linting errors. It could be great to have 2 entries for paths to ignore :

marcguyer commented 5 years ago

👍for this. I'm a little surprised that it's not possible already. Often, dependencies loaded into /vendor, for example, are loaded with linter errors. Those aren't fixable within the project so the errors/warnings are simply noise, making it difficult to see what I can fix. I thought maybe a workaround would be to exclude the /vendor directory temporarily but then my code is littered with errors about missing classes, etc, since they're in /vendor. The best workaround I can find is to use the filter functionality in the diagnostics pane. Unfortunately that only works for the diagnostics pane while the "global" errors/warnings indicator in the lower left still shows errors outside the filter.

Perhaps the feature request should be to add a filter config option that's also honored by the global indicator... Or something along those lines...

Gert-dev commented 4 years ago

I'm closing this, since it should no longer be a problem with Serenata 5.0 as it doesn't do any semantic linting anymore, just syntax linting, which shouldn't be a problem for vendor files, I think, if there are any, you'll probably want to know about them since they will cause trouble for indexing as well.