Gert-dev / php-ide-serenata

Atom IDE package that integrates the Serenata server to provide PHP code assistance
https://serenata.gitlab.io/
Other
274 stars 19 forks source link

seperate index root from project root #459

Closed TitanNano closed 5 years ago

TitanNano commented 5 years ago

I have a couple of projects which are extensions to existing applications, e.g. Shopware, WordPress etc. In order for these to work properly I currently have to set the project root to the root of the parent application so all the relevant files get indexed. Unfortunately this breaks other atom extensions which require the project root to be the actual root directory of the project, so they pick up the right config file. These extensions are eslint, sasslint, atom-tern and more.

Would it be possible to create an "index root" setting for projects so Serenata knows about all the files, but we can set the right project folder in atom?

Gert-dev commented 5 years ago

It should be possible and only require adding a configuration option to the new config file (in 5.0), which will then be indexed instead of the project root.

I've created a ticket for this on the server here. I'll still leave this open here, since this package will generate a default configuration file for you that should also include this new directive.

Gert-dev commented 5 years ago

Just wanted to note that this is going to be supported in the next major version that uses Serenata 5.0 (see also #460). The project path will only be used as a fallback if no explicit project configuration is provided.

One or more URIs can be configured in the project settings as documented here in Serenata 5.

Gert-dev commented 5 years ago

I've released v5.0, closing this. Feel free to create new tickets for bugs.