search

Gert-dev / php-ide-serenata

Atom IDE package that integrates the Serenata server to provide PHP code assistance
https://serenata.gitlab.io/
Other
274 stars 19 forks source link

Upgrade to 4.5.2 breaks communication with Serenata < 5 #468

Closed edomato closed 5 years ago

edomato commented 5 years ago

After Atom upgraded the plugin from 4.5.1 to 4.5.2, every request that sends to the server has wrong parameters names if serenata version is < 5.

This seems to be the problem

Or at least that's what I found :grin:

Greets. Ernesto

edomato commented 5 years ago

Well, seems that the problem is confirmed in the sense that I downgraded to 4.5.1 and it started working again :smile:

Greets. Ernesto

ameenross commented 5 years ago

Same problem

Gert-dev commented 5 years ago

I forgot I wrote some code towards 5.0 on the master branch and accidentally published that whilst it should have been on the feature/lsp-client branch.

I've now reverted it and did a new release that excludes those changes.