search

Gert-dev / php-ide-serenata

Atom IDE package that integrates the Serenata server to provide PHP code assistance
https://serenata.gitlab.io/
Other
275 stars 19 forks source link

Updating to “php-ide-serenata@5.0.0” failed on Windows #477

Closed underdpt closed 4 years ago

underdpt commented 4 years ago

When upgrading to latest php-ide-serenata v5.0.0 it throws an error in windows, due to the command rm being used (but it doesn't exists on windows):

npm ERR! prepareGitDep 1> 
npm ERR! prepareGitDep > atom-languageclient@0.9.9 prepare C:\Users\user\.atom\.apm\_cacache\tmp\git-clone-5d2a9ffc
npm ERR! prepareGitDep > npm run clean && npm run compile
npm ERR! prepareGitDep 
npm ERR! prepareGitDep 
npm ERR! prepareGitDep > atom-languageclient@0.9.9 clean C:\Users\user\.atom\.apm\_cacache\tmp\git-clone-5d2a9ffc
npm ERR! prepareGitDep > rm -rf build
npm ERR! prepareGitDep 
npm ERR! prepareGitDep 
npm ERR! prepareGitDep 2> npm WARN install Usage of the `--dev` option is deprecated. Use `--only=dev` instead.
**npm ERR! prepareGitDep "rm" no se reconoce como un comando interno o externo,**
npm ERR! prepareGitDep programa o archivo por lotes ejecutable.
npm ERR! prepareGitDep npm ERR! code ELIFECYCLE
npm ERR! prepareGitDep npm ERR! errno 1
npm ERR! prepareGitDep npm ERR! atom-languageclient@0.9.9 clean: `rm -rf build`
npm ERR! prepareGitDep npm ERR! Exit status 1
npm ERR! prepareGitDep npm ERR! 
npm ERR! prepareGitDep npm ERR! Failed at the atom-languageclient@0.9.9 clean script.
npm ERR! prepareGitDep npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

The resalted line says "rm" is not recognized as an external or internal command.

uzuzoo commented 4 years ago

Same Issue as @underdpt

UziTech commented 4 years ago

https://github.com/atom/atom-languageclient/pull/276 should fix it

Gert-dev commented 4 years ago

This does appear to be an issue with the atom-languageclient package.

As a workaround, you may be able to fix this by removing the php-ide-serenata package folder first and then reinstalling. In that case it may skip trying to remove the previous directory.

Once the pull request is merged in atom-languageclient, I'll try targeting the unstable commit to fix the problem here as well - at least if it doesn't break anything else, so I'll leave this open.

underdpt commented 4 years ago

Thanks @Gert-dev

Removing the package and package folder didn't help (also tried removing the atom-languageclient folder). Will wait for the fix.

putude commented 4 years ago

FYI, Same problem here. Using Win 10 64bit.

Gert-dev commented 4 years ago

Another workaround that you can try is (in your Atom packages folder):

This will likely fix it, but you will likely run into an issue where autocompleting e.g. @inher will result in @@inheritDoc.

I'm now wondering if I shouldn't just revert to that in master; the issue of not being able to install is probably worse than the autocompletion bug.

UziTech commented 4 years ago

I agree, especially since it seems atom has no intention of releasing a new version of atom-languageclient any time soon.

The other solution could be forking atom-languageclient and using your own fork until they decide to fix it in the main repo.

Gert-dev commented 4 years ago

Alright, I'm going to revert to 0.9.9. I've created #487 to track the issue it reintroduces.