search

Gert-dev / php-ide-serenata

Atom IDE package that integrates the Serenata server to provide PHP code assistance
https://serenata.gitlab.io/
Other
275 stars 22 forks source link

Code Lenses break "ALT + LMB" multi line cursors #486

Closed madrussa closed 4 years ago

madrussa commented 4 years ago

When adding multiple cursors within Atom using the ALT + LMB the first cursor jumps the number of code lenses added above the selection down.

If there are 3 interface methods above the text you want select with ALT + LMB, the cursors jump 3 lines down from where you want to select from.

image In the example above I started selecting from line 56, but as there are 2 implementation code lenses above, it starts adding cursors from line 58.

Using the keyboard shortcuts (ie. CRTL + SHIFT + [UP|DOWN]) work as expected, so it maybe this issue should be reported to Atom as well? As the ALT + LMB to only count code lines above and not interface lines.

Update: ALT + LMB seems to be a "Sublime Style Column Selection" implemenation.

Gert-dev commented 4 years ago

I'm wondering if this is indeed an Atom issue of some kind, I'm not experiencing this behavior:

Peek 2019-10-09 18-44

As you can see, I'm seeing the expected behavior both with the keyboard as well as mouse. In my case, ctrl-shift-click is the shortcut for placing Atom's cursors.

Did I understand the update correctly in that alt+lmb is custom functionality implemented by Sublime Style Column Selection? In that case it may be a bug in that package not taking Atom's text buffer decorations into account.

madrussa commented 4 years ago

Yes, I've launched an issue with the author of the column selection https://github.com/bigfive/atom-sublime-select/issues/167. Thanks for looking though!

Gert-dev commented 4 years ago

@madrussa Okay, good to hear. I'll close this, since it didn't turn out to be an issue here.

Anyway, thanks for taking the time to report issues!