search

Gert-dev / php-ide-serenata

Atom IDE package that integrates the Serenata server to provide PHP code assistance
https://serenata.gitlab.io/
Other
275 stars 22 forks source link

Autocompletion for docblock tags does not replace @ #487

Closed Gert-dev closed 2 years ago

Gert-dev commented 4 years ago

Autocompletion for docblock tags such as @inheritDoc does not seem to replace the existing @, it is likely the replacementPrefix is not set correctly (or the server is providing the wrong textEdit that does not include it in its range)

It turns out this is caused by atom-languageclient, reported upstream at atom/atom-languageclient#266.

I targeted the upstream release for #460, but targeting unstable Git versions breaks package installation for Windows users (#477), so that was reverted. Hence this is an issue again. We should probably wait until a new stable version is released.

machitgarha commented 2 years ago

The issue still exists. It is really annoying, because it is not limited only to doc-blocks; it happens on variable dollar signs and explicit global namespaces (e.g. \Exceptions becomes \\Exception).

Is it still related to atom-languageclient?

cristianlivella commented 2 years ago

Has anything been updated in the last few days? I've been using this plugin for a few months now and never had problem with this, but now I have this very annoying problem with the dollar sign, which makes the plugin practically unusable.

Every time I select a variable from the autocomplete, either with the tab or enter key or mouse click, I get an extra dollar added.

edit: I can't understand why I see this problem just now, however I solved it by removing $ from "non word characters" in the package language-php settings.