search

Gert-dev / php-ide-serenata

Atom IDE package that integrates the Serenata server to provide PHP code assistance
https://serenata.gitlab.io/
Other
275 stars 22 forks source link

can't work for php7.4 #495

Closed juvevood closed 4 years ago

juvevood commented 4 years ago

please support php 7.4. it doen't work now on 5.1 version. Thanks!

The PHP server has errors to report: PHP Notice: Trying to access array offset on value of type null in phar:///home/juve/.cache/php-ide-serenata/distribution.phar/builds/Serenata/Serenata/src/Indexing/Visiting/ClasslikeIndexingVisitor.php on line 772 PHP Notice: Trying to access array offset on value of type null in phar:///home/juve/.cache/php-ide-serenata/distribution.phar/builds/Serenata/Serenata/src/Indexing/Visiting/ClasslikeIndexingVisitor.php on line 843

Gert-dev commented 4 years ago

Support for running on PHP 7.4 is coming in the next Serenata release.

If you really need or want it now, there are already nightly builds available for PHP 7.4. You can download the job artifacts, extract the PHAR and replace the downloaded one in the Serenata folder in your home folder with this one, which should get you up and running until the next release happens.

I'll close this since this is something that needs to happen in upstream Serenata. You can create an issue there, if you like, but since it's already done, there isn't any need, since it's already coming :-).