search

Gert-dev / php-ide-serenata

Atom IDE package that integrates the Serenata server to provide PHP code assistance
https://serenata.gitlab.io/
Other
275 stars 22 forks source link

Suggestion: Add option to disable php-ide-serenata.general.projectOpenCount #499

Open sbrl opened 4 years ago

sbrl commented 4 years ago

I use the sync-settings package to synchronise my Atom settings across devices. Recently, it's been popping up every time I start Atom to tell me that the settings have changed, and I need to choose whether to backup or restore:

Selection_010

When I click "view diff", I'm greeted with this:

Selection_011

It looks like Serenata is now keeping track of the number of times I've opened projects. This is really annoying - and slightly creepy. Is there any way to disable this? It doesn't seem to be obviously used for anything.

Gert-dev commented 4 years ago

I'm not familiar with how settings synchronization works, but I understand the annoyance. I think you you can avoid this by setting general.doNotAskForSupport to true.

There's really no point in incrementing this number beyond the current threshold of 10. The number is used to show a notification to the user "when he's been using the package for some time" (though some users may reach 10 project opens in a single day, whilst others might take months).

It's not sent anywhere or used anywhere else than in the linked location, in case you're worried about analytics/tracking - I don't like these myself, so I wanted to make the notification as unobtrusive as possible and allow permanently disabling it this way.

I will leave this open so we can move updating the setting only to when the threshold is not yet reached (i.e. move it inside the if statement below it).

sbrl commented 4 years ago

Ah, thanks for that! I'll see if that fix works in the coming days.

I've actually been experiencing a number of crashes in Serenata too (it's been really unstable) - but I need to track that down before I can open a separate bug report about that.