search

Gert-dev / php-ide-serenata

Atom IDE package that integrates the Serenata server to provide PHP code assistance
https://serenata.gitlab.io/
Other
275 stars 22 forks source link

Revert prefix override workaround #521

Closed machitgarha closed 3 years ago

machitgarha commented 3 years ago

It seems the upstream bug in atom-languageclient no longer exists (after the transition from atom into atom-ide-community), so the workaround for filtering and sorting is no longer needed. As I tested, the extension works perfectly with this change (i.e. without the workaround).

Closes #501 and #485. Should close #489 as well.

machitgarha commented 3 years ago

@Gert-dev Any updates on this one?

nelson6e65 commented 3 years ago

Hmm... How can I try this?

machitgarha commented 3 years ago

@nelson6e65

For a quick fix, do the steps mentioned in this comment.

Gert-dev commented 3 years ago

Thanks for taking the time to invest this and send this pull request. I haven't used in Atom in quite some time, as I might have implied in some other tickets already, but it's good to see that the community is picking up where Microsoft/GitHub/Facebook left it off.

Judging by the various comments in the issues and your post, I'll take your word for that it is now obsolete and merge this.

machitgarha commented 3 years ago

@Gert-dev

Thanks for your confidence. :)