search

Gert-dev / php-ide-serenata

Atom IDE package that integrates the Serenata server to provide PHP code assistance
https://serenata.gitlab.io/
Other
275 stars 22 forks source link

Fix ESLint issues, improve classes #528

Closed machitgarha closed 2 years ago

machitgarha commented 2 years ago

Targetting #433.

machitgarha commented 2 years ago

Looking at commit diffs is better (for reviewers).

Gert-dev commented 2 years ago

Not sure if you were waiting for my review, but these changes look fine to me.

Looking back now makes me realize how much the ecosystem has changed (again) since then - the code being refactored now was a conversion from CoffeeScript (remember that? :smile:).

Not necessary for this MR, but maybe it's a good idea to customize the ESLint ruleset to your liking (if you want), and then let it autofix as much as possible. For the formatting, you could try something like Prettier, as it can also autoformat pretty much everything.

machitgarha commented 2 years ago

Well, CoffeeScript? A subset of Coffee language? 😁

I'm not really familiar with the JavaScript ecosystem, but I might have to get my hands dirty with it. So thanks for the tip, I would try that.

And, good to hear you reviewed it! Thanks!